Conversation
Kubuxu
force-pushed
the
feat/f3-map-reduce
branch
from
c6be17e to
1574b0c
Compare
masih
reviewed
May 21, 2025
Member
masih
left a comment
masih
left a comment
There was a problem hiding this comment.
The integration here looks straightforward (ec.go) 👍
Signed-off-by: Jakub Sztandera <oss@kubuxu.com>
Signed-off-by: Jakub Sztandera <oss@kubuxu.com>
Signed-off-by: Jakub Sztandera <oss@kubuxu.com>
Kubuxu
force-pushed
the
feat/f3-map-reduce
branch
from
1574b0c to
e416216
Compare
masih
reviewed
May 22, 2025
Signed-off-by: Jakub Sztandera <oss@kubuxu.com>
masih
approved these changes
May 22, 2025
github-project-automation
bot
moved this from 📌 Triage
to ✔️ Approved by reviewer
in FilOz
Member
|
I think the improvements introduced here deserve an entry in the changelog. nice work Kuba! 🍻 |
Signed-off-by: Jakub Sztandera <oss@kubuxu.com>
masih
approved these changes
May 22, 2025
github-project-automation
bot
moved this from ✔️ Approved by reviewer
to 🎉 Done
in FilOz
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR integrates MapReduce cache. The replace directives are temporary.
The mess in go-state-types integration is non-optimal, but I could not find a better solution.