chore: increase the F3 GMessage buffer size to 1024#13126
Merged
Conversation
The GMessage buffer size is a non-consensus breaking parameter. It's a headroom beyond which pubsub will start dropping messages before they are seen by the F3 message processing logic. During passive testing of F3 on mainnet we increased this buffer from its default value of 128 twice. We still observe reports by SPs that indicate the increased value may still not be enough for all cases. Increasing the buffer size is a low-risk parameter to adjust since the increase in memory consumption is negligible. The root cause of the need for larger buffer size is slow state read in Lotus which consequently slows the serialised flow of message processing in F3. Work is under way to improve the efficiency of Lotus state fetch call that should reduce the reliance on larger buffers. But considering the small cost of having slightly larger buffers, it's worthwhile to do both. Fixes #13103
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Please update the PR title to match https://github.com/filecoin-project/lotus/blob/master/CONTRIBUTING.md#pr-title-conventions
masih
changed the title
github-actions
bot
dismissed
their stale review
PR title now matches the required format.
rvagg
approved these changes
May 13, 2025
github-project-automation
bot
moved this from ⌨️ In Progress
to ✔️ Approved by reviewer
in FilOz
Kubuxu
approved these changes
May 14, 2025
github-project-automation
bot
moved this from ✔️ Approved by reviewer
to 🎉 Done
in FilOz
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The GMessage buffer size is a non-consensus breaking parameter. It's a headroom beyond which pubsub will start dropping messages before they are seen by the F3 message processing logic.
During passive testing of F3 on mainnet we increased this buffer from its default value of 128 twice. We still observe reports by SPs that indicate the increased value may still not be enough for all cases. Increasing the buffer size is a low-risk parameter to adjust since the increase in memory consumption is negligible.
The root cause of the need for larger buffer size is slow state read in Lotus which consequently slows the serialised flow of message processing in F3. Work is under way to improve the efficiency of Lotus state fetch call that should reduce the reliance on larger buffers. But considering the small cost of having slightly larger buffers, it's worthwhile to do both.
Fixes #13103