Skip to content

fix(test): make immutable deadline check more conservative #13112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rvagg merged 1 commit into from
May 21, 2025
+8 −3
Merged

fix(test): make immutable deadline check more conservative #13112

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions itests/kit/node_unmanaged.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -803,7 +803,7 @@ func (tm *TestUnmanagedMiner) submitProveCommit(

// Step 6: Submit the ProveCommit to the network
if proofType.IsNonInteractive() {
if tm.IsImmutableDeadline(provingDeadline) {
if tm.MaybeImmutableDeadline(provingDeadline) {
// avoid immutable deadlines
provingDeadline = 5
}
Expand Down Expand Up @@ -1701,12 +1701,17 @@ func (tm *TestUnmanagedMiner) AssertDisputeFails(sector abi.SectorNumber) {
req.Contains(err.Error(), "(RetCode=16)")
}

func (tm *TestUnmanagedMiner) IsImmutableDeadline(deadlineIndex uint64) bool {
// MaybeImmutableDeadline checks if the deadline index is immutable. Immutable deadlines are defined
// as being the current deadline for the miner or their next deadline. But we also include the
// deadline after the next deadline in our check here to be conservative to avoid race conditions of
// the chain progressing before messages land.
func (tm *TestUnmanagedMiner) MaybeImmutableDeadline(deadlineIndex uint64) bool {
req := require.New(tm.t)
di, err := tm.FullNode.StateMinerProvingDeadline(tm.ctx, tm.ActorAddr, types.EmptyTSK)
req.NoError(err)
currentDeadlineIdx := CurrentDeadlineIndex(di)
return currentDeadlineIdx == deadlineIndex || currentDeadlineIdx == deadlineIndex-1
// Check if deadlineIndex is the current, next, or the one after next.
return deadlineIndex >= currentDeadlineIdx && deadlineIndex <= currentDeadlineIdx+2
}

// CurrentDeadlineIndex manually calculates the current deadline index. This may be useful in
Expand Down