Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions cmd/release/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -346,12 +346,15 @@ func main() {
issueBody := issueBodyBuffer.String()

// Remove duplicate newlines before headers and list items since the templating leaves a lot extra newlines around.
// Extra newlines are present because go formatting control statements done within HTML comments rather than using {{- -}}.
// Extra newlines are present because go formatting control statements are done within HTML comments rather than using {{- -}}.
// HTML comments are used instead so that the template file parses as clean markdown on its own.
// In addition, HTML comments were also required within "ranges" in the template.
// Using HTML comments everywhere keeps things consistent.
re := regexp.MustCompile(`\n\n+([^#*\[\|])`)
issueBody = re.ReplaceAllString(issueBody, "\n$1")
// The one exception is after `</summary>` tags. In that case we preserve the newlines,
// as without newlines the section doesn't do markdown formatting on GitHub.
// Since Go regexp doesn't support negative lookbehind, we just look for any non ">".
re := regexp.MustCompile(`([^>])\n\n+([^#*\[\|])`)
issueBody = re.ReplaceAllString(issueBody, "$1\n$2")

if !createOnGitHub {
// Create the URL-encoded parameters
Expand Down
9 changes: 5 additions & 4 deletions documentation/misc/RELEASE_ISSUE_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
# ✅ Release Checklist

## ⬅️ Before RC1
<details one>
<details open>
<summary>Section</summary>

<!--{{if ne .NetworkUpgrade ""}}-->
Expand Down Expand Up @@ -123,7 +123,6 @@
<!-- {{end}}-->

#### Release PR for {{$rc}}

- [ ] Update the version string(s) in `build/version.go` to one {{if contains "rc" $rc}}ending with '-{{$rc}}'{{else}}**NOT* ending with 'rcX'{{end}}.
<!-- {{if contains "Node" $.Type}}-->
- Ensure to update `NodeBuildVersion`
Expand Down Expand Up @@ -159,21 +158,23 @@
- Link to issue comment:

#### Testing for {{$rc}}

> [!NOTE]
> Link to any special steps for testing releases beyond ensuring CI is green. Steps can be inlined here or tracked elsewhere.

<!--{{end}}-->
</details>
<!--{{end}}-->

## ➡ Post-Release
<details>
<summary open>Section</summary>
<summary>Section</summary>

- [ ] Open a PR against `master` cherry-picking the CHANGELOG commits from the `release/v{{.Tag}}` branch. Title it `chore(release): cherry-pick v{{.Tag}} changelog back to master`
- Link to PR:
- Assuming we followed [the process of merging changes into `master` first before backporting to the release branch](https://github.com/filecoin-project/lotus/blob/master/LOTUS_RELEASE_FLOW.md#branch-and-tag-strategy), the only changes should be CHANGELOG updates.
- [ ] Finish updating/merging the [RELEASE_ISSUE_TEMPLATE.md](https://github.com/filecoin-project/lotus/blob/master/documentation/misc/RELEASE_ISSUE_TEMPLATE.md) PR from `Before RC1` with any improvements determined from this latest release iteration.
- [ ] Review and approve the auto-generated PR in [lotus-docs](https://github.com/filecoin-project/lotus-docs/pulls) that updates the latest Lotus version information.
- [ ] Review and approve the auto-generated PR in [homebrew-lotus](https://github.com/filecoin-project/homebrew-lotus/pulls) that updates the homebrew to the latest Lotus version.
- [ ] Stage any security advisories for future publishing per [policy](https://github.com/filecoin-project/lotus/blob/master/LOTUS_RELEASE_FLOW.md#security-fix-policy).
</details>

Expand Down
Loading