feat: fall back to EC if F3 finalized tipeset is older than 900 epochs#13066
Merged
feat: fall back to EC if F3 finalized tipeset is older than 900 epochs#13066
Conversation
In Lotus v2 APIs, in an event where F3 finalized tipset is too far behind EC, > 900 epochs return EC finalized tipset. Part of: #13062
BigLep
reviewed
Apr 24, 2025
Member
BigLep
left a comment
BigLep
left a comment
There was a problem hiding this comment.
Conceptually seems right/good to me and good to see a test. Will leave to someone else who commits code to the repo to approve.
Kubuxu
approved these changes
Apr 25, 2025
Contributor
Kubuxu
left a comment
Kubuxu
left a comment
There was a problem hiding this comment.
It feels weird that this code is so duplicated
I'm cautious about needing finality resolution in more places. Once the third duplicate appears, let's refactor it out.
github-project-automation
Bot
moved this from 📌 Triage
to ✔️ Approved by reviewer
in FilOz
Member
Author
Yes. A lot of refactoring needed. |
github-project-automation
Bot
moved this from ✔️ Approved by reviewer
to 🎉 Done
in FilOz
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Lotus v2 APIs, in an event where F3 finalized tipset is too far behind EC, > 900 epochs return EC finalized tipset.
Part of: #13062