chore(miner): remove deprecated code as a result of FIP-0100#13049
chore(miner): remove deprecated code as a result of FIP-0100#13049rvagg merged 4 commits intofilecoin-project:masterfrom
Conversation
There was a problem hiding this comment.
Please update the PR title to match https://github.com/filecoin-project/lotus/blob/master/CONTRIBUTING.md#pr-title-conventions
There was a problem hiding this comment.
Please update the PR title to match https://github.com/filecoin-project/lotus/blob/master/CONTRIBUTING.md#pr-title-conventions
There was a problem hiding this comment.
Please update the PR title to match https://github.com/filecoin-project/lotus/blob/master/CONTRIBUTING.md#pr-title-conventions
PR title now matches the required format.
PR title now matches the required format.
|
@Stebalien : can you please look given @rvagg is out? |
|
(This is followup to #12919 now that we've upgraded to nv25) |
|
@rvagg : I assume you'll look later this week when you come back online. |
|
@rvagg could you look over the latest changes here, and see if things look okay so that we can get it merged? |
|
@rvagg : repinging in case you have bandwidth now for this. |
There was a problem hiding this comment.
Pull Request Overview
This PR removes deprecated aggregation and basefee-threshold code per FIP-0100.
- Consolidates partition/declaration limits by using
policy.DeclarationsMax. - Drops deprecated config fields (
AggregateCommits,AggregateAboveBaseFee,BatchPreCommitAboveBaseFee) and related logic. - Cleans up default configs, CLI commands, policy actors, and tests to eliminate FIP-0100 leftovers.
Reviewed Changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| storage/wdpost/wdpost_run.go | Use policy.DeclarationsMax instead of deprecated GetDeclarationsMax |
| storage/pipeline/terminate_batch.go | Remove deprecated FIP-0100 declaration-limit checks |
| storage/pipeline/sealiface/config.go | Drop deprecated aggregation-and-fee config fields |
| storage/pipeline/precommit_batch.go | Remove basefee-threshold batching logic |
| storage/pipeline/commit_batch.go | Remove aggregation flags and outdated fee computation |
| node/modules/storageminer.go | Remove deprecated sealing config assignments |
| node/config/types.go | Delete deprecated config options |
| node/config/doc_gen.go | Clean up documentation for removed config fields |
| node/config/def.go | Remove deprecated default config values |
| itests/sector_pledge_test.go | Update tests to drop deprecated fee-threshold config mutation |
| itests/sector_miner_collateral_test.go | Remove obsolete aggregation settings in test setup |
| itests/direct_data_onboard_test.go | Remove outdated aggregate setting from test configuration |
| documentation/en/default-lotus-miner-config.toml | Clean default config file of deprecated entries |
| cli/spcli/sectors.go | Replace deprecated GetDeclarationsMax usage with DeclarationsMax |
| chain/actors/policy/policy.go.template | Remove deprecated policy-template methods |
| chain/actors/policy/policy.go | Remove deprecated policy methods |
Comments suppressed due to low confidence (1)
storage/pipeline/commit_batch.go:223
- Use
%winstead of%swhen formatting errors so the original error can be properly wrapped and unwrapped.
return nil, xerrors.Errorf("getting network version: %s", err)
2755132 to
ade0ac9
Compare
ade0ac9 to
8315eb7
Compare
|
I've added a CHANGELOG entry in here and rebased on master. @rjan90 I'll let you adjust changelog through the release process if it doesn't suit your preferences. |
Related Issues
Proposed Changes
Additional Info
Checklist
Before you mark the PR ready for review, please make sure that: