fix(deps): fix Ledger hardware wallet support#13048
Merged
rjan90 merged 1 commit intofilecoin-project:masterfrom Apr 21, 2025
Merged
fix(deps): fix Ledger hardware wallet support#13048rjan90 merged 1 commit intofilecoin-project:masterfrom
rjan90 merged 1 commit intofilecoin-project:masterfrom
Conversation
When using some Ledger Nano hardware wallets, some commands fail with:
ERROR: finding ledger: LedgerHID device (idx 0) not found.
Ledger LOCKED OR Other Program/Web Browser may have control of device.
Examples are `lotus wallet new secp256k1-ledger` and `lotus-shed ledger list`.
This issue was fixed upstream in Zondax/ledger-go#40,
which then got pulled in Zondax/ledger-filecoin-go#38,
which was released as https://github.com/Zondax/ledger-filecoin-go/releases/tag/v1.0.1.
So the fix is to simply update to `ledger-filecoin-go` v1.0.1, which is all
that this PR does.
rjan90
approved these changes
Apr 21, 2025
Contributor
rjan90
left a comment
rjan90
left a comment
There was a problem hiding this comment.
Thank you so much for the PR 🙏
github-project-automation
Bot
moved this from 🔎 Awaiting Review
to ✔️ Approved by reviewer
in FilOz
github-project-automation
Bot
moved this from ✔️ Approved by reviewer
to 🎉 Done
in FilOz
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes
So the fix is to simply update to
ledger-filecoin-gov1.0.1, which is all that this PR does.Additional Info
When using some Ledger Nano hardware wallets, some commands fail with:
Examples are
lotus wallet new secp256k1-ledgerandlotus-shed ledger list.This issue was fixed upstream in Zondax/ledger-go#40, which then got pulled in Zondax/ledger-filecoin-go#38, which was released as https://github.com/Zondax/ledger-filecoin-go/releases/tag/v1.0.1.
Checklist
Before you mark the PR ready for review, please make sure that: