Skip to content

chore: avoid test flakiness in v2 API tests caused by WaitTillChain #13033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
masih merged 1 commit into from
Apr 11, 2025
Merged

chore: avoid test flakiness in v2 API tests caused by WaitTillChain #13033

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions itests/api_v2_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,8 +179,11 @@ func TestAPIV2_ThroughRPC(t *testing.T) {
mockF3.latestCert = nil
mockF3.latestCertErr = nil
},
request: `{"jsonrpc":"2.0","method":"Filecoin.ChainGetTipSet","params":[{"height":{"at":20}}],"id":1}`,
wantTipSet: tipSetAtHeight(20),
// Lookup a height that is sufficiently behind the epoch at WaitTillChain + a
// little bit further back to avoid race conditions of WaitTillChain
// implementation which can cause flaky tests.
request: `{"jsonrpc":"2.0","method":"Filecoin.ChainGetTipSet","params":[{"height":{"at":15}}],"id":1}`,
wantTipSet: tipSetAtHeight(15),
wantResponseStatus: http.StatusOK,
},
{
Expand Down
Loading