feat(metrics): capture gas metrics from ApplyBlocks, tweak time buckets#13030
Merged
feat(metrics): capture gas metrics from ApplyBlocks, tweak time buckets#13030
Conversation
rvagg
force-pushed
the
rvagg/apply-blocks-metrics
branch
from
ff71a2c to
87c30d5
Compare
rvagg
removed
the
skip/changelog
masih
approved these changes
Apr 11, 2025
github-project-automation
Bot
moved this from 📌 Triage
to ✔️ Approved by reviewer
in FilOz
github-project-automation
Bot
moved this from ✔️ Approved by reviewer
to 🎉 Done
in FilOz
Member
Author
|
Nicer with the new bucketing: 
And now we can compare with gas! 
|
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I want to capture some gas values from message execution, but I'm also concerned about the quantisation of our timing metrics, particularly in the 1s - 2s range, I think it leads to weird graphs where our "total"
ApplyBlockstime snaps to 1.99s and then bounces between some lower quantisation levels, when it should be the sum of the other 3 metrics collected withinApplyBlocks(early, messages and cron), but the sum of those 3 is never close to total.I have this running at the moment and will report back with a new screenshot also with gas when I've collected enough.