Skip to content

refactor: use slices.Equal to simplify code #13002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rvagg merged 1 commit into from
Apr 2, 2025
Merged

refactor: use slices.Equal to simplify code #13002

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 2 additions & 11 deletions chain/types/tipset.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import (
"encoding/json"
"fmt"
"io"
"slices"
"sort"

"github.com/ipfs/go-cid"
Expand Down Expand Up @@ -172,17 +173,7 @@ func (ts *TipSet) Equals(ots *TipSet) bool {
return false
}

if len(ts.cids) != len(ots.cids) {
return false
}

for i, cid := range ts.cids {
if cid != ots.cids[i] {
return false
}
}

return true
return slices.Equal(ts.cids, ots.cids)
}

func (t *Ticket) Less(o *Ticket) bool {
Expand Down
Loading