chore(eth): make EthGetBlockByNumber & EthGetBlockByHash share cache code#12979
Merged
chore(eth): make EthGetBlockByNumber & EthGetBlockByHash share cache code#12979
Conversation
7 tasks
…code Both will benefit from the same cache and be impacted by EthBlkCacheSize Ref: #12977
rvagg
force-pushed
the
rvagg/EthGetBlockByBleh
branch
from
7943c78 to
3ad9dd5
Compare
Member
|
@masih : can you please review (if it hasn't been reviewed already)? |
Member
|
Or actually, maybe it makes sense to have @aarshkshah1992 look at this given he has been engaged on slack: https://filecoinproject.slack.com/archives/C03TM2QDTHN/p1742736711386359?thread_ts=1742285258.489549&cid=C03TM2QDTHN |
masih
approved these changes
Mar 25, 2025
github-project-automation
Bot
moved this from 🔎 Awaiting Review
to ✔️ Approved by reviewer
in FilOz
Co-authored-by: Masih H. Derkani <m@derkani.org>
github-project-automation
Bot
moved this from ✔️ Approved by reviewer
to 🎉 Done
in FilOz
This was referenced Mar 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both will benefit from the same cache and be impacted by EthBlkCacheSize
Ref: #12977
(Also some minor fixups in here to rename some vars to what they should have been, when I refactored this originally most interfaces were "providers", hence the
pin the names.)