Skip to content

feat: add Agent to Filecoin.Version !#12953

Merged
masih merged 1 commit intofilecoin-project:masterfrom
LesnyRumcajs:add-agent-type-version
Mar 14, 2025
Merged

feat: add Agent to Filecoin.Version !#12953
masih merged 1 commit intofilecoin-project:masterfrom
LesnyRumcajs:add-agent-type-version

Conversation

@LesnyRumcajs
Copy link
Copy Markdown
Contributor

@LesnyRumcajs LesnyRumcajs commented Mar 14, 2025

Related Issues

Closes #12904

Proposed Changes

Added Agent to the Filecoin.Version. Depending on the client's deserialization capabilities, this is a potentially breaking change.

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

@github-project-automation github-project-automation Bot moved this to 📌 Triage in FilOz Mar 14, 2025
@LesnyRumcajs LesnyRumcajs marked this pull request as ready for review March 14, 2025 11:24
Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-project-automation github-project-automation Bot moved this from 📌 Triage to ⌨️ In Progress in FilOz Mar 14, 2025
@LesnyRumcajs LesnyRumcajs changed the title !feat: add Agent to Filecoin.Version feat: add Agent to Filecoin.Version ! Mar 14, 2025
@github-actions github-actions Bot dismissed their stale review March 14, 2025 11:25

PR title now matches the required format.

@rjan90 rjan90 moved this from ⌨️ In Progress to 🔎 Awaiting Review in FilOz Mar 14, 2025
@rjan90
Copy link
Copy Markdown
Contributor

rjan90 commented Mar 14, 2025

Tested in a devnet:

curl -X POST http://localhost:1234/rpc/v0 \
     -H "Content-Type: application/json" \
     -d '{
           "jsonrpc": "2.0",
           "method": "Filecoin.Version",
           "params": [],
           "id": 1
         }'
{"id":1,"jsonrpc":"2.0","result":{"Version":"1.32.1-dev+2k+git.8d6d554e8","APIVersion":66816,"BlockDelay":4,"Agent":"lotus"}}

Copy link
Copy Markdown
Contributor

@rjan90 rjan90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me based on the testing I have done, but would be good to have an additional ✅ from maybe @masih ?

@github-project-automation github-project-automation Bot moved this from 🔎 Awaiting Review to ✔️ Approved by reviewer in FilOz Mar 14, 2025
@masih masih merged commit 926d924 into filecoin-project:master Mar 14, 2025
@github-project-automation github-project-automation Bot moved this from ✔️ Approved by reviewer to 🎉 Done in FilOz Mar 14, 2025
rvagg pushed a commit that referenced this pull request Mar 18, 2025
feat: add Agent to `Filecoin.Version`
rvagg pushed a commit that referenced this pull request Mar 18, 2025
feat: add Agent to `Filecoin.Version`
@rjan90 rjan90 moved this from 🎉 Done to ☑️ Done (Archive) in FilOz Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ☑️ Done (Archive)

Development

Successfully merging this pull request may close these issues.

Add Node Agent Type to 'Filecoin.Version'

3 participants