Skip to content

fix: prevent panic in FullNodeProxy with empty node list#12948

Merged
rjan90 merged 1 commit intomasterfrom
phi/fix-panic
Mar 13, 2025
Merged

fix: prevent panic in FullNodeProxy with empty node list#12948
rjan90 merged 1 commit intomasterfrom
phi/fix-panic

Conversation

@rjan90
Copy link
Copy Markdown
Contributor

@rjan90 rjan90 commented Mar 12, 2025

fix: prevent panic in FullNodeProxy with empty node list

Related Issues

Fixes #12931

Proposed Changes

  • Add check in FullNodeProxy to prevent panic when called with an empty node list

Checklist

Before you mark the PR ready for review, please make sure that:

fix: prevent panic in FullNodeProxy with empty node list
@rjan90 rjan90 added the skip/changelog This change does not require CHANGELOG.md update label Mar 12, 2025
@rjan90 rjan90 requested a review from Kubuxu March 12, 2025 13:24
@github-project-automation github-project-automation Bot moved this to 📌 Triage in FilOz Mar 12, 2025
@rjan90 rjan90 self-assigned this Mar 12, 2025
@rjan90 rjan90 moved this from 📌 Triage to 🔎 Awaiting Review in FilOz Mar 12, 2025
@github-project-automation github-project-automation Bot moved this from 🔎 Awaiting Review to ✔️ Approved by reviewer in FilOz Mar 13, 2025
@rjan90 rjan90 merged commit b8718a8 into master Mar 13, 2025
@rjan90 rjan90 deleted the phi/fix-panic branch March 13, 2025 13:38
@github-project-automation github-project-automation Bot moved this from ✔️ Approved by reviewer to 🎉 Done in FilOz Mar 13, 2025
rvagg pushed a commit that referenced this pull request Mar 18, 2025
fix: prevent panic in FullNodeProxy with empty node list

fix: prevent panic in FullNodeProxy with empty node list
rvagg pushed a commit that referenced this pull request Mar 18, 2025
fix: prevent panic in FullNodeProxy with empty node list

fix: prevent panic in FullNodeProxy with empty node list
@rjan90 rjan90 moved this from 🎉 Done to ☑️ Done (Archive) in FilOz Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip/changelog This change does not require CHANGELOG.md update

Projects

Status: ☑️ Done (Archive)

Development

Successfully merging this pull request may close these issues.

Node panics, instead on returning error when FullNodeProxy is called with empty nodes.

2 participants