fix: f3: topic filter with no static manifest#12943
Merged
Conversation
Signed-off-by: Jakub Sztandera <oss@kubuxu.com>
rjan90
approved these changes
Mar 10, 2025
Contributor
rjan90
left a comment
There was a problem hiding this comment.
Updating the Butterfly network nodes to this branch got F3 unblocked:
lotus f3 status
Running: true
Progress:
Instance: 53
Round: 0
Phase: INITIAL
Manifest:
Protocol Version: 6
Paused: false
Initial Instance: 0
Initial Power Table: bafy2bzacedrwea2z2orechafcuyrvgxteebx2snpipwjx6mmfyssfzsqjhzf4
Bootstrap Epoch: 29000
Network Name: butterflynet
Ignore EC Power: false
Committee Lookback: 10
Catch Up Alignment: 15s
GPBFT Delta: 6s
GPBFT Delta BackOff Exponent: 2
GPBFT Quality Delta Multiplier: 1
GPBFT Max Lookahead Rounds: 5
GPBFT Chain Proposed Length: 100
GPBFT Rebroadcast Backoff Base: 6s
GPBFT Rebroadcast Backoff Exponent: 1.3
GPBFT Rebroadcast Backoff Spread: 0.1
GPBFT Rebroadcast Backoff Max: 1m0s
EC Period: 30s
EC Finality: 900
EC Delay Multiplier: 2
EC Head Lookback: 0
EC Finalize: true
Certificate Exchange Client Timeout: 10s
Certificate Exchange Server Timeout: 1m0s
Certificate Exchange Min Poll Interval: 30s
Certificate Exchange Max Poll Interval: 2m0s
PubSub Compression Enabled: false
Chain Exchange Subscription Buffer Size: 32
Chain Exchange Max Chain Length: 100
Chain Exchange Max Instance Lookahead: 10
Chain Exchange Max Discovered Chains Per Instance: 1000
Chain Exchange Max Wanted Chains Per Instance: 1000
Chain Exchange Rebroadcast Interval: 2s
Chain Exchange Max Timestamp Age: 8s
A sanity ✅ from Masih would be great though
masih
approved these changes
Mar 10, 2025
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code would only allow the main network pubsub topic if the static manifest were specified.
Not sure how that slipped through my manual tests. I think I was testing it with the code that was overriding static manifest with contract one, and only later I made the two options exclusive.