Skip to content

fix: f3: topic filter with no static manifest#12943

Merged
Kubuxu merged 1 commit intomasterfrom
f3/fix-pubsub-topic-no-static
Mar 10, 2025
Merged

fix: f3: topic filter with no static manifest#12943
Kubuxu merged 1 commit intomasterfrom
f3/fix-pubsub-topic-no-static

Conversation

@Kubuxu
Copy link
Copy Markdown
Contributor

@Kubuxu Kubuxu commented Mar 10, 2025

The code would only allow the main network pubsub topic if the static manifest were specified.
Not sure how that slipped through my manual tests. I think I was testing it with the code that was overriding static manifest with contract one, and only later I made the two options exclusive.

Signed-off-by: Jakub Sztandera <oss@kubuxu.com>
@github-project-automation github-project-automation Bot moved this to 📌 Triage in FilOz Mar 10, 2025
@Kubuxu Kubuxu added the skip/changelog This change does not require CHANGELOG.md update label Mar 10, 2025
@Kubuxu Kubuxu requested a review from masih March 10, 2025 14:53
Copy link
Copy Markdown
Contributor

@rjan90 rjan90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating the Butterfly network nodes to this branch got F3 unblocked:

lotus f3 status
Running: true
Progress:
  Instance: 53
  Round:    0
  Phase:    INITIAL
Manifest:
  Protocol Version:     6
  Paused:               false
  Initial Instance:     0
  Initial Power Table:  bafy2bzacedrwea2z2orechafcuyrvgxteebx2snpipwjx6mmfyssfzsqjhzf4
  Bootstrap Epoch:      29000
  Network Name:         butterflynet
  Ignore EC Power:      false
  Committee Lookback:   10
  Catch Up Alignment:   15s

  GPBFT Delta:                        6s
  GPBFT Delta BackOff Exponent:       2
  GPBFT Quality Delta Multiplier:     1
  GPBFT Max Lookahead Rounds:         5
  GPBFT Chain Proposed Length:        100
  GPBFT Rebroadcast Backoff Base:     6s
  GPBFT Rebroadcast Backoff Exponent: 1.3
  GPBFT Rebroadcast Backoff Spread:   0.1
  GPBFT Rebroadcast Backoff Max:      1m0s

  EC Period:            30s
  EC Finality:          900
  EC Delay Multiplier:  2
  EC Head Lookback:     0
  EC Finalize:          true

  Certificate Exchange Client Timeout:    10s
  Certificate Exchange Server Timeout:    1m0s
  Certificate Exchange Min Poll Interval: 30s
  Certificate Exchange Max Poll Interval: 2m0s

  PubSub Compression Enabled:  false

  Chain Exchange Subscription Buffer Size:           32
  Chain Exchange Max Chain Length:                   100
  Chain Exchange Max Instance Lookahead:             10
  Chain Exchange Max Discovered Chains Per Instance: 1000
  Chain Exchange Max Wanted Chains Per Instance:     1000
  Chain Exchange Rebroadcast Interval:               2s
  Chain Exchange Max Timestamp Age:                  8s

A sanity ✅ from Masih would be great though

@github-project-automation github-project-automation Bot moved this from 📌 Triage to ✔️ Approved by reviewer in FilOz Mar 10, 2025
@rjan90 rjan90 moved this to Done in F3 Mar 10, 2025
@Kubuxu Kubuxu merged commit 241ce6d into master Mar 10, 2025
@Kubuxu Kubuxu deleted the f3/fix-pubsub-topic-no-static branch March 10, 2025 15:54
@github-project-automation github-project-automation Bot moved this from ✔️ Approved by reviewer to 🎉 Done in FilOz Mar 10, 2025
@rjan90 rjan90 moved this from 🎉 Done to ☑️ Done (Archive) in FilOz Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip/changelog This change does not require CHANGELOG.md update

Projects

Status: Done
Status: ☑️ Done (Archive)

Development

Successfully merging this pull request may close these issues.

3 participants