fix: delegate integer operations to go-state-types#12935
Merged
Conversation
Stebalien
added
the
skip/changelog
This delegates most calls to go-state-types and treats "nil" as "zero" (we encode nil as zero, so we might as well treat it as such when doing math).
Stebalien
force-pushed
the
steb/big-int-delegate
branch
from
d74521b to
fdd623d
Compare
Member
Author
|
Honestly, I think we should merge this no matter how we want to handle nil/zeros. |
rvagg
approved these changes
Mar 6, 2025
Member
rvagg
left a comment
rvagg
left a comment
There was a problem hiding this comment.
Agreed, this is good regardless, but let's see if that test failure was a flaky or not first
github-project-automation
Bot
moved this from 📌 Triage
to ✔️ Approved by reviewer
in FilOz
github-project-automation
Bot
moved this from ✔️ Approved by reviewer
to 🎉 Done
in FilOz
Member
Author
|
Looks like they're all passing now. |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Delegates most calls to go-state-types and treats "nil" as "zero" (we encode nil as zero, so we might as well treat it as such when doing math).
Additional Info
@rvagg just in case we want to do it this way.
Checklist
Before you mark the PR ready for review, please make sure that: