chore: use the correct environment variable for proof params path#12891
Merged
chore: use the correct environment variable for proof params path#12891
Conversation
The actual environment variable that sets the proof params fetch path is `FIL_PROOFS_PARAMETER_CACHE` according to `go-paramfetch` implementation. See: * https://github.com/filecoin-project/go-paramfetch/blob/62ad5888f87076c9589d2b63af904b1f89a91b86/paramfetch.go#L31 Fix it in `Dockerfile` to avoid redundant download of params if the wrong env var is set.
Contributor
|
Gave a head-up to Curio here in Slack, as I see they are also using |
rjan90
approved these changes
Feb 11, 2025
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The actual environment variable that sets the proof params fetch path is
FIL_PROOFS_PARAMETER_CACHEaccording togo-paramfetchimplementation. See:Fix it in
Dockerfileto avoid redundant download of params if the wrong env var is set.