Skip to content

chore(test): skip unfixed flaky gateway limits test#12888

Merged
rvagg merged 2 commits intomasterfrom
rvagg/gateway-limits-skip
Feb 11, 2025
Merged

chore(test): skip unfixed flaky gateway limits test#12888
rvagg merged 2 commits intomasterfrom
rvagg/gateway-limits-skip

Conversation

@rvagg
Copy link
Copy Markdown
Member

@rvagg rvagg commented Feb 11, 2025

I'll drop some notes in #12566 further to the comment I'm leaving in here. It's been flaky too long and hasn't been prioritised to be fixed.

@rvagg rvagg requested review from BigLep and rjan90 February 11, 2025 03:57
@rvagg rvagg added the skip/changelog This change does not require CHANGELOG.md update label Feb 11, 2025
Copy link
Copy Markdown
Member

@BigLep BigLep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it customary to add a link to the tracking issue where the FIXME will occur (#12566 )?

Comment thread itests/gateway_test.go
@rvagg
Copy link
Copy Markdown
Member Author

rvagg commented Feb 11, 2025

good call, done

@rvagg rvagg enabled auto-merge (squash) February 11, 2025 06:04
@rvagg rvagg merged commit dee78a3 into master Feb 11, 2025
@rvagg rvagg deleted the rvagg/gateway-limits-skip branch February 11, 2025 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip/changelog This change does not require CHANGELOG.md update

Projects

Status: ☑️ Done (Archive)

Development

Successfully merging this pull request may close these issues.

3 participants