chore(blockstore): add an LRU cache to the API blockstore wrapper#12878
Merged
chore(blockstore): add an LRU cache to the API blockstore wrapper#12878
Conversation
masih
approved these changes
Feb 7, 2025
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been relying on
NewAPIBlockstorea lot lately for lotus-shed commands, miscellaneous things to inspect state mainly, where I don't want to stop my node to mount it as the blockstore. But realised that a lot of the fetches are for the same small blocks because we have a lot of things like THE empty partition, THE empty deadline, THE empty HAMT. It turns out that putting a simple LRU in there makes it so much faster to do simple iteration and checking when you're hitting these things.This is mainly used in lotus-shed, but it has a few uses in the
lotuscommand, specifically for some things underlotus filplus,lotus miner infoandlotus multisig. Thespclicommands also use this a little.