Skip to content

refactor(eth): attach ToFilecoinMessage converter to EthCall.#12844

Merged
rjan90 merged 2 commits intomasterfrom
phi/refactor-eth-message
Jan 24, 2025
Merged

refactor(eth): attach ToFilecoinMessage converter to EthCall.#12844
rjan90 merged 2 commits intomasterfrom
phi/refactor-eth-message

Conversation

@rjan90
Copy link
Copy Markdown
Contributor

@rjan90 rjan90 commented Jan 23, 2025

Reviving the work by @raulk (all credits to him) from #12062, which did not land due to a failing test and because the original function that was refactored has moved a bit.

Proposed Changes

Small refactor to clean things up:

  • This converter is better placed as an EthCall method instead of a package-level function.
  • The resulting package/module import graph is sane.
  • Exporting this as a public method is very helpful for those who use Lotus as a library.

Checklist

Before you mark the PR ready for review, please make sure that:

refactor(eth): attach ToFilecoinMessage converter to EthCall.
chore: add changelog entry
@rjan90 rjan90 marked this pull request as ready for review January 23, 2025 12:28
@rjan90 rjan90 requested a review from Stebalien January 24, 2025 12:20
@rjan90 rjan90 merged commit a90ee17 into master Jan 24, 2025
@rjan90 rjan90 deleted the phi/refactor-eth-message branch January 24, 2025 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ☑️ Done (Archive)

Development

Successfully merging this pull request may close these issues.

2 participants