feat(eth): check events are indexed within in requested range#12808
Merged
feat(eth): check events are indexed within in requested range#12808
Conversation
Initial work, not yet complete.
Complete work from #12728
rvagg
force-pushed
the
akaladarshi/check-logs-index-range
branch
from
42351ed to
ef5b7b7
Compare
Member
|
@aarshkshah1992 : can you please look at this week so we close this out? |
Contributor
|
Reviewing this today. Apologies for the delay folks ! |
aarshkshah1992
approved these changes
Jan 29, 2025
Contributor
aarshkshah1992
left a comment
aarshkshah1992
left a comment
There was a problem hiding this comment.
just a few nits but looks solid
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a continuation of @akaladarshi's excellent work in #12728, finishing it up and making it mergeable. Original commit squashed from that PR is retained here, with just a small extra one by me added on top.