Skip to content

chore: use time.Since instead of time.Now().Sub#12801

Merged
rvagg merged 4 commits intofilecoin-project:masterfrom
asamuj:chore/time-since
Dec 30, 2024
Merged

chore: use time.Since instead of time.Now().Sub#12801
rvagg merged 4 commits intofilecoin-project:masterfrom
asamuj:chore/time-since

Conversation

@asamuj
Copy link
Copy Markdown
Contributor

@asamuj asamuj commented Dec 20, 2024

Related Issues

Proposed Changes

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

@rvagg rvagg added the skip/changelog This change does not require CHANGELOG.md update label Dec 20, 2024
Comment thread cmd/lotus-miner/storage.go Outdated
Comment thread cmd/lotus-miner/storage.go Outdated
Comment thread storage/paths/local.go Outdated
@rvagg
Copy link
Copy Markdown
Member

rvagg commented Dec 20, 2024

Thanks for this @asamuj, some nice cleanups in here. I have a local branch with all of these time.Since fixes, but I was also working my way through some additional staticcheck complaints before I bothered pushing it, but you beat me to this!
My only request is to wind back the 0 -> 0o changes you've made, otherwise I'm happy with this.

asamuj and others added 3 commits December 20, 2024 16:33
Co-authored-by: Rod Vagg <rod@vagg.org>
Co-authored-by: Rod Vagg <rod@vagg.org>
Co-authored-by: Rod Vagg <rod@vagg.org>
Copy link
Copy Markdown
Member

@rvagg rvagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌 nice, thanks

@rvagg rvagg merged commit bbd53a6 into filecoin-project:master Dec 30, 2024
@asamuj asamuj deleted the chore/time-since branch December 30, 2024 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip/changelog This change does not require CHANGELOG.md update

Projects

Status: ☑️ Done (Archive)

Development

Successfully merging this pull request may close these issues.

2 participants