fix: make DealStatesEqual work properly#12783
Merged
Conversation
Stebalien
approved these changes
Dec 13, 2024
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure this is even needed. I also don't know if
SectorNumbershould be considered here, it wasn't on the original form and I only added it because that would seem to be appropriate for completeness.My short git detective walk suggests the
emptyDealState#Equalsmethod contents was deduped withDealStatesEqualas part of the DDO work in #11226, but the wrong way around, ooops. So I'm flipping it back, but also addingSectorNumberbecause that would seem more correct 🤷♂️ ; depends on how this is used.There's one use in
StatePredicates#DealStateChangedForIDsbut I can't see that being used anywhere.There's one use in
marketStatesDiffer#Modifyas part of theDiffAdtArray. Downstream from this it's used byStatePredicates#OnDealStateAmtChanged, but I can't see that being used anywhere either.