Skip to content

fix(sync): mark blocks which diverge from checkpoint as bad#12763

Merged
rvagg merged 2 commits intomasterfrom
kubuxu/fix/sync-mark-bad
Dec 9, 2024
Merged

fix(sync): mark blocks which diverge from checkpoint as bad#12763
rvagg merged 2 commits intomasterfrom
kubuxu/fix/sync-mark-bad

Conversation

@Kubuxu
Copy link
Copy Markdown
Contributor

@Kubuxu Kubuxu commented Dec 5, 2024

Resolves flake in TestSyncCheckpointHead

Not certain why this was flaky, it would mean that sometimes the forking
tipset would not hit this case.

Resolves: #12758

Resolves flake in `TestSyncCheckpointHead`

Not certain why this was flaky, it would mean that sometimes the forking
tipset would not hit this case.

Signed-off-by: Jakub Sztandera <oss@kubuxu.com>
@Kubuxu Kubuxu added the skip/changelog This change does not require CHANGELOG.md update label Dec 5, 2024
Signed-off-by: Jakub Sztandera <oss@kubuxu.com>
@BigLep BigLep requested a review from rvagg December 5, 2024 17:33
@Kubuxu Kubuxu requested a review from Stebalien December 6, 2024 14:14
Copy link
Copy Markdown
Member

@rvagg rvagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@rvagg rvagg merged commit e145ef5 into master Dec 9, 2024
@rvagg rvagg deleted the kubuxu/fix/sync-mark-bad branch December 9, 2024 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip/changelog This change does not require CHANGELOG.md update

Projects

Status: ☑️ Done (Archive)

Development

Successfully merging this pull request may close these issues.

New flaky: TestSyncCheckpointHead

2 participants