Skip to content

chore(test): unflake TestTraceFilter #12759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rvagg merged 1 commit into from
Dec 6, 2024
Merged

chore(test): unflake TestTraceFilter #12759

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions itests/eth_transactions_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -876,12 +876,17 @@ func TestTraceFilter(t *testing.T) {
hc := <-ch // current
require.Equal(t, store.HCCurrent, hc[0].Type)
beforeNullHeight := hc[0].Val.Height()
hc = <-ch // wait for next block
require.Equal(t, store.HCApply, hc[0].Type)
afterNullHeight := hc[0].Val.Height()
require.Greater(t, afterNullHeight, beforeNullHeight+1)
hc = <-ch // one more, so "latest" points to the block after nulls
require.Equal(t, store.HCApply, hc[0].Type)
var blocks int
for {
hc = <-ch // wait for next block
require.Equal(t, store.HCApply, hc[0].Type)
if hc[0].Val.Height() > beforeNullHeight {
blocks++
if blocks == 2 { // two blocks, so "latest" points to the block after nulls
break
}
}
}

// define filter criteria that spans a null round so it has to at lest consider it
toBlock = "latest"
Expand Down