feat: improve semantics for returning reverted events to event API users #12585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvagg
reviewed
Oct 11, 2024
rvagg
reviewed
Oct 11, 2024
rvagg
reviewed
Oct 11, 2024
rvagg
reviewed
Oct 11, 2024
|
Turned my long message into a PR: #12586 which we'll merge here shortly |
rvagg
force-pushed
the
fix/get-logs-reverted-events
branch
5 times, most recently
from
0b053cc
to
2fef9eb
Compare
Apply suggestions from code review Co-authored-by: Rod Vagg <[email protected]>
* subscribe-type calls always wants future reverts but only historical reverts when a tipset is specified * get-type calls only want reverts when a tipset is specified Add a new Fill() method to avoid the unnecessary install + remove step for get- type calls. Closes: #12584
rvagg
force-pushed
the
fix/get-logs-reverted-events
branch
from
2fef9eb
to
b4eb48b
Compare
rvagg
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #12584.
-Event APIs should only returns reverted events if client has queries by block hash rather than epoch.