Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(f3): send the last gpbft message for each new participant #12577

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

Stebalien
Copy link
Member

Proposed Changes

Send the last gpbft message for each new participant.

Otherwise, we can get into a situation where everyone is waiting for the next round to participate, but we'll never get there because not enough participants acted in the current round.

Checklist

Before you mark the PR ready for review, please make sure that:

@Stebalien Stebalien added the skip/changelog This change does not require CHANGELOG.md update label Oct 10, 2024
@Stebalien Stebalien force-pushed the steb/broadcast-current-message branch from 928eb17 to 5efee6a Compare October 10, 2024 19:22
@Stebalien
Copy link
Member Author

I'm going to write an itest where:

  1. One node participates from the beginning.
  2. Later, all the other nodes start participating.

@Stebalien Stebalien force-pushed the steb/broadcast-current-message branch 3 times, most recently from 21ffb56 to 60516e8 Compare October 10, 2024 22:25
@Stebalien Stebalien requested review from masih and Kubuxu and removed request for masih October 10, 2024 22:52
@Stebalien
Copy link
Member Author

I'm going to have to refactor a few things to make this testable. I'd prefer to merge this as-is and merge the test later after the refactor.

@Stebalien Stebalien force-pushed the steb/broadcast-current-message branch from 60516e8 to a158336 Compare October 11, 2024 03:10
Copy link
Contributor

@Kubuxu Kubuxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change SGWM but itests seem unhappy.

Otherwise, we can get into a situation where everyone is waiting for the
next round to participate, but we'll never get there because not enough
participants acted in the current round.
@Stebalien Stebalien force-pushed the steb/broadcast-current-message branch from a158336 to d300fa1 Compare October 11, 2024 13:44
@Stebalien Stebalien merged commit 47b7525 into master Oct 11, 2024
82 of 83 checks passed
@Stebalien Stebalien deleted the steb/broadcast-current-message branch October 11, 2024 14:00
@Stebalien
Copy link
Member Author

Stebalien commented Oct 11, 2024

The tests have been failing across all the F3 PRs regardless.

rjan90 pushed a commit that referenced this pull request Oct 14, 2024
Otherwise, we can get into a situation where everyone is waiting for the
next round to participate, but we'll never get there because not enough
participants acted in the current round.
rjan90 pushed a commit that referenced this pull request Oct 14, 2024
Otherwise, we can get into a situation where everyone is waiting for the
next round to participate, but we'll never get there because not enough
participants acted in the current round.
rjan90 pushed a commit that referenced this pull request Oct 14, 2024
Otherwise, we can get into a situation where everyone is waiting for the
next round to participate, but we'll never get there because not enough
participants acted in the current round.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip/changelog This change does not require CHANGELOG.md update
Projects
Status: ☑️ Done (Archive)
Development

Successfully merging this pull request may close these issues.

3 participants