-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(f3): send the last gpbft message for each new participant #12577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
added
the
skip/changelog
This change does not require CHANGELOG.md update
label
Oct 10, 2024
Stebalien
force-pushed
the
steb/broadcast-current-message
branch
from
October 10, 2024 19:22
928eb17
to
5efee6a
Compare
I'm going to write an itest where:
|
Stebalien
force-pushed
the
steb/broadcast-current-message
branch
3 times, most recently
from
October 10, 2024 22:25
21ffb56
to
60516e8
Compare
Stebalien
requested review from
masih and
Kubuxu
and removed request for
masih
October 10, 2024 22:52
I'm going to have to refactor a few things to make this testable. I'd prefer to merge this as-is and merge the test later after the refactor. |
Stebalien
force-pushed
the
steb/broadcast-current-message
branch
from
October 11, 2024 03:10
60516e8
to
a158336
Compare
Kubuxu
approved these changes
Oct 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change SGWM but itests seem unhappy.
Otherwise, we can get into a situation where everyone is waiting for the next round to participate, but we'll never get there because not enough participants acted in the current round.
Stebalien
force-pushed
the
steb/broadcast-current-message
branch
from
October 11, 2024 13:44
a158336
to
d300fa1
Compare
The tests have been failing across all the F3 PRs regardless. |
44 tasks
rjan90
pushed a commit
that referenced
this pull request
Oct 14, 2024
Otherwise, we can get into a situation where everyone is waiting for the next round to participate, but we'll never get there because not enough participants acted in the current round.
rjan90
pushed a commit
that referenced
this pull request
Oct 14, 2024
Otherwise, we can get into a situation where everyone is waiting for the next round to participate, but we'll never get there because not enough participants acted in the current round.
rjan90
pushed a commit
that referenced
this pull request
Oct 14, 2024
Otherwise, we can get into a situation where everyone is waiting for the next round to participate, but we'll never get there because not enough participants acted in the current round.
6 tasks
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Send the last gpbft message for each new participant.
Otherwise, we can get into a situation where everyone is waiting for the next round to participate, but we'll never get there because not enough participants acted in the current round.
Checklist
Before you mark the PR ready for review, please make sure that: