Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: ci: create gh workflow that updates sorted pr checks #11861

Merged
merged 3 commits into from
Apr 22, 2024
Merged

ci: ci: create gh workflow that updates sorted pr checks #11861

merged 3 commits into from
Apr 22, 2024

Conversation

galargh
Copy link
Contributor

@galargh galargh commented Apr 9, 2024 •
edited
Loading

Related Issues

#11734

Proposed Changes

I propose to introduce a workflow that is going to post a nicely formatted list of completed checks on a PR once all the GitHub Actions workflow runs finish for the PR in question.

Additional Info

The issue with GitHub PR Checks was originally reported here - https://filecoinproject.slack.com/archives/CP50PPW2X/p1711707107172389

Unfortunately, it is unlikely to be resolved by GitHub any time soon - https://github.com/orgs/community/discussions/7885

We developed an alternative solution to the problem that relies on posting a sticky comment to a PR which a sorted/grouped list of checks after all the GitHub Actions workflows are finished - https://github.com/ipdxco/sorted-pr-checks

Please note that the comment only includes information about GitHub Actions workflows, it does NOT include CircleCI checks.

We can choose between two(three) flavours of the comment:
A. Sorted by result and then alphabetically - #11861 (comment)
B. Grouped by result and then sorted alphabetically within the group - #11861 (comment)
C. Create a new comment template

Given the number of checks that we have here, I'd suggest the grouped comment.

There is one more alternative solution to the problem. The Refined GitHub extension - https://github.com/refined-github/refined-github - implements GitHub status checks sorting. While the extension is really useful and makes using GitHub nicer, I don't think we can rely on it and expect all contributors to install it. That's why I'd suggest proceeding with the introduction of this workflow nonetheless.

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • If the PR affects users (e.g., new feature, bug fix, system requirements change), update the CHANGELOG.md and add details to the UNRELEASED section.
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@galargh galargh force-pushed the ipdx-gha-sorted-pr-checks branch from 9c12cc9 to 7f43105 Compare April 9, 2024 11:06
@galargh galargh force-pushed the ipdx-gha-sorted-pr-checks branch from 7f43105 to b4101f7 Compare April 9, 2024 11:07
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 9, 2024 •
edited
Loading

All checks have completed

✅ Successful Build / Build (pull_request)
✅ Successful Check / Check (docs-check) (pull_request)
✅ Successful Check / Check (gen-check) (pull_request)
✅ Successful Check / Check (gofmt) (pull_request)
✅ Successful Check / Check (lint-all) (pull_request)
✅ Successful Check / Check (mod-tidy-check) (pull_request)
✅ Successful Comment with sorted PR checks / comment / Comment (workflow_dispatch)
✅ Successful Comment with sorted PR checks / comment / Comment (workflow_dispatch)
✅ Successful Comment with sorted PR checks / comment / Comment (workflow_dispatch)
✅ Successful PR #11861 / Analyze (go) (dynamic)
✅ Successful Test / Cache Dependencies (pull_request)
✅ Successful Test / Discover Test Groups (pull_request)
✅ Successful Test / Test (conformance) (pull_request)
✅ Successful Test / Test (itest-api) (pull_request)
✅ Successful Test / Test (itest-batch_deal) (pull_request)
✅ Successful Test / Test (itest-cli) (pull_request)
✅ Successful Test / Test (itest-curio) (pull_request)
✅ Successful Test / Test (itest-deadlines) (pull_request)
✅ Successful Test / Test (itest-deals) (pull_request)
✅ Successful Test / Test (itest-deals_512mb) (pull_request)
✅ Successful Test / Test (itest-deals_anycid) (pull_request)
✅ Successful Test / Test (itest-deals_concurrent) (pull_request)
✅ Successful Test / Test (itest-deals_invalid_utf8_label) (pull_request)
✅ Successful Test / Test (itest-deals_max_staging_deals) (pull_request)
✅ Successful Test / Test (itest-deals_offline) (pull_request)
✅ Successful Test / Test (itest-deals_padding) (pull_request)
✅ Successful Test / Test (itest-deals_partial_retrieval) (pull_request)
✅ Successful Test / Test (itest-deals_partial_retrieval_dm-level) (pull_request)
✅ Successful Test / Test (itest-deals_power) (pull_request)
✅ Successful Test / Test (itest-deals_pricing) (pull_request)
✅ Successful Test / Test (itest-deals_publish) (pull_request)
✅ Successful Test / Test (itest-deals_remote_retrieval) (pull_request)
✅ Successful Test / Test (itest-deals_retry_deal_no_funds) (pull_request)
✅ Successful Test / Test (itest-decode_params) (pull_request)
✅ Successful Test / Test (itest-direct_data_onboard) (pull_request)
✅ Successful Test / Test (itest-direct_data_onboard_verified) (pull_request)
✅ Successful Test / Test (itest-dup_mpool_messages) (pull_request)
✅ Successful Test / Test (itest-eth_account_abstraction) (pull_request)
✅ Successful Test / Test (itest-eth_api) (pull_request)
✅ Successful Test / Test (itest-eth_balance) (pull_request)
✅ Successful Test / Test (itest-eth_block_hash) (pull_request)
✅ Successful Test / Test (itest-eth_bytecode) (pull_request)
✅ Successful Test / Test (itest-eth_config) (pull_request)
✅ Successful Test / Test (itest-eth_conformance) (pull_request)
✅ Successful Test / Test (itest-eth_deploy) (pull_request)
✅ Successful Test / Test (itest-eth_fee_history) (pull_request)
✅ Successful Test / Test (itest-eth_filter) (pull_request)
✅ Successful Test / Test (itest-eth_hash_lookup) (pull_request)
✅ Successful Test / Test (itest-eth_transactions) (pull_request)
✅ Successful Test / Test (itest-fevm) (pull_request)
✅ Successful Test / Test (itest-fevm_address) (pull_request)
✅ Successful Test / Test (itest-fevm_events) (pull_request)
✅ Successful Test / Test (itest-gas_estimation) (pull_request)
✅ Successful Test / Test (itest-gateway) (pull_request)
✅ Successful Test / Test (itest-get_messages_in_ts) (pull_request)
✅ Successful Test / Test (itest-harmonydb) (pull_request)
✅ Successful Test / Test (itest-harmonytask) (pull_request)
✅ Successful Test / Test (itest-lite_migration) (pull_request)
✅ Successful Test / Test (itest-lookup_robust_address) (pull_request)
✅ Successful Test / Test (itest-mempool) (pull_request)
✅ Successful Test / Test (itest-migration) (pull_request)
✅ Successful Test / Test (itest-mpool_msg_uuid) (pull_request)
✅ Successful Test / Test (itest-mpool_push_with_uuid) (pull_request)
✅ Successful Test / Test (itest-msgindex) (pull_request)
✅ Successful Test / Test (itest-multisig) (pull_request)
✅ Successful Test / Test (itest-net) (pull_request)
✅ Successful Test / Test (itest-nonce) (pull_request)
✅ Successful Test / Test (itest-path_detach_redeclare) (pull_request)
✅ Successful Test / Test (itest-path_type_filters) (pull_request)
✅ Successful Test / Test (itest-paych_api) (pull_request)
✅ Successful Test / Test (itest-paych_cli) (pull_request)
✅ Successful Test / Test (itest-pending_deal_allocation) (pull_request)
✅ Successful Test / Test (itest-remove_verifreg_datacap) (pull_request)
✅ Successful Test / Test (itest-sealing_resources) (pull_request)
✅ Successful Test / Test (itest-sector_finalize_early) (pull_request)
✅ Successful Test / Test (itest-sector_import_full) (pull_request)
✅ Successful Test / Test (itest-sector_import_simple) (pull_request)
✅ Successful Test / Test (itest-sector_miner_collateral) (pull_request)
✅ Successful Test / Test (itest-sector_numassign) (pull_request)
✅ Successful Test / Test (itest-sector_pledge) (pull_request)
✅ Successful Test / Test (itest-sector_terminate) (pull_request)
✅ Successful Test / Test (itest-sector_unseal) (pull_request)
✅ Successful Test / Test (itest-self_sent_txn) (pull_request)
✅ Successful Test / Test (itest-splitstore) (pull_request)
✅ Successful Test / Test (itest-verifreg) (pull_request)
✅ Successful Test / Test (itest-wdpost) (pull_request)
✅ Successful Test / Test (itest-wdpost_config) (pull_request)
✅ Successful Test / Test (itest-wdpost_dispute) (pull_request)
✅ Successful Test / Test (itest-wdpost_no_miner_storage) (pull_request)
✅ Successful Test / Test (itest-wdpost_worker_config) (pull_request)
✅ Successful Test / Test (itest-worker) (pull_request)
✅ Successful Test / Test (itest-worker_upgrade) (pull_request)
✅ Successful Test / Test (multicore-sdr) (pull_request)
✅ Successful Test / Test (unit-cli) (pull_request)
✅ Successful Test / Test (unit-node) (pull_request)
✅ Successful Test / Test (unit-rest) (pull_request)
✅ Successful Test / Test (unit-storage) (pull_request)
✅ Successful Unknown / CodeQL (unknown)

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 9, 2024 •
edited
Loading

All checks have completed

✅ Successful (95)

Build / Build (pull_request)
Check / Check (docs-check) (pull_request)
Check / Check (gen-check) (pull_request)
Check / Check (gofmt) (pull_request)
Check / Check (lint-all) (pull_request)
Check / Check (mod-tidy-check) (pull_request)
PR #11861 / Analyze (go) (dynamic)
Test / Cache Dependencies (pull_request)
Test / Discover Test Groups (pull_request)
Test / Test (conformance) (pull_request)
Test / Test (itest-api) (pull_request)
Test / Test (itest-batch_deal) (pull_request)
Test / Test (itest-cli) (pull_request)
Test / Test (itest-curio) (pull_request)
Test / Test (itest-deadlines) (pull_request)
Test / Test (itest-deals) (pull_request)
Test / Test (itest-deals_512mb) (pull_request)
Test / Test (itest-deals_anycid) (pull_request)
Test / Test (itest-deals_concurrent) (pull_request)
Test / Test (itest-deals_invalid_utf8_label) (pull_request)
Test / Test (itest-deals_max_staging_deals) (pull_request)
Test / Test (itest-deals_offline) (pull_request)
Test / Test (itest-deals_padding) (pull_request)
Test / Test (itest-deals_partial_retrieval) (pull_request)
Test / Test (itest-deals_partial_retrieval_dm-level) (pull_request)
Test / Test (itest-deals_power) (pull_request)
Test / Test (itest-deals_pricing) (pull_request)
Test / Test (itest-deals_publish) (pull_request)
Test / Test (itest-deals_remote_retrieval) (pull_request)
Test / Test (itest-deals_retry_deal_no_funds) (pull_request)
Test / Test (itest-decode_params) (pull_request)
Test / Test (itest-direct_data_onboard) (pull_request)
Test / Test (itest-direct_data_onboard_verified) (pull_request)
Test / Test (itest-dup_mpool_messages) (pull_request)
Test / Test (itest-eth_account_abstraction) (pull_request)
Test / Test (itest-eth_api) (pull_request)
Test / Test (itest-eth_balance) (pull_request)
Test / Test (itest-eth_block_hash) (pull_request)
Test / Test (itest-eth_bytecode) (pull_request)
Test / Test (itest-eth_config) (pull_request)
Test / Test (itest-eth_conformance) (pull_request)
Test / Test (itest-eth_deploy) (pull_request)
Test / Test (itest-eth_fee_history) (pull_request)
Test / Test (itest-eth_filter) (pull_request)
Test / Test (itest-eth_hash_lookup) (pull_request)
Test / Test (itest-eth_transactions) (pull_request)
Test / Test (itest-fevm) (pull_request)
Test / Test (itest-fevm_address) (pull_request)
Test / Test (itest-fevm_events) (pull_request)
Test / Test (itest-gas_estimation) (pull_request)
Test / Test (itest-gateway) (pull_request)
Test / Test (itest-get_messages_in_ts) (pull_request)
Test / Test (itest-harmonydb) (pull_request)
Test / Test (itest-harmonytask) (pull_request)
Test / Test (itest-lite_migration) (pull_request)
Test / Test (itest-lookup_robust_address) (pull_request)
Test / Test (itest-mempool) (pull_request)
Test / Test (itest-migration) (pull_request)
Test / Test (itest-mpool_msg_uuid) (pull_request)
Test / Test (itest-mpool_push_with_uuid) (pull_request)
Test / Test (itest-msgindex) (pull_request)
Test / Test (itest-multisig) (pull_request)
Test / Test (itest-net) (pull_request)
Test / Test (itest-nonce) (pull_request)
Test / Test (itest-path_detach_redeclare) (pull_request)
Test / Test (itest-path_type_filters) (pull_request)
Test / Test (itest-paych_api) (pull_request)
Test / Test (itest-paych_cli) (pull_request)
Test / Test (itest-pending_deal_allocation) (pull_request)
Test / Test (itest-remove_verifreg_datacap) (pull_request)
Test / Test (itest-sealing_resources) (pull_request)
Test / Test (itest-sector_finalize_early) (pull_request)
Test / Test (itest-sector_import_full) (pull_request)
Test / Test (itest-sector_import_simple) (pull_request)
Test / Test (itest-sector_miner_collateral) (pull_request)
Test / Test (itest-sector_numassign) (pull_request)
Test / Test (itest-sector_pledge) (pull_request)
Test / Test (itest-sector_terminate) (pull_request)
Test / Test (itest-sector_unseal) (pull_request)
Test / Test (itest-self_sent_txn) (pull_request)
Test / Test (itest-splitstore) (pull_request)
Test / Test (itest-verifreg) (pull_request)
Test / Test (itest-wdpost) (pull_request)
Test / Test (itest-wdpost_config) (pull_request)
Test / Test (itest-wdpost_dispute) (pull_request)
Test / Test (itest-wdpost_no_miner_storage) (pull_request)
Test / Test (itest-wdpost_worker_config) (pull_request)
Test / Test (itest-worker) (pull_request)
Test / Test (itest-worker_upgrade) (pull_request)
Test / Test (multicore-sdr) (pull_request)
Test / Test (unit-cli) (pull_request)
Test / Test (unit-node) (pull_request)
Test / Test (unit-rest) (pull_request)
Test / Test (unit-storage) (pull_request)
Unknown / CodeQL (unknown)

@galargh galargh marked this pull request as ready for review April 9, 2024 11:58
@galargh galargh changed the title ci: create gh workflow that updates sorted pr checks ci: ci: create gh workflow that updates sorted pr checks Apr 9, 2024
@galargh galargh requested review from rvagg and magik6k April 9, 2024 11:59
@Stebalien
Copy link
Member

Is there any way to just post failures? Although I guess they're fine if we group them.

@Stebalien
Copy link
Member

Eh, I don't have strong preferences.

@masih
Copy link
Member

masih commented Apr 10, 2024 •
edited
Loading

I am not sure if this is worth having, TBH. It seems like a lot of duplicate information?

I believe the PR author would get an email notification of the failed CI workflow anyway and that should make it obvious what failed.

If we absolutely want this, then only comment when there is a failure and only include failures?

@galargh
Copy link
Contributor Author

galargh commented Apr 11, 2024

Is there any way to just post failures? Although I guess they're fine if we group them.

Yes, of course. I added a new template for the comment that would skip successful checks. The comment, if something fails, would look something like this - ipdxco/sorted-pr-checks#5 (comment)

I am not sure if this is worth having, TBH. It seems like a lot of duplicate information?

Yes, all the information about the checks is available but not easily discoverable. The comment provides an easier way to find what failed among almost a hundred checks. The need for this addition was raised in https://filecoinproject.slack.com/archives/CP50PPW2X/p1711707107172389

I believe the PR author would get an email notification of the failed CI workflow anyway, and that should make what failed obvious.

Yes - https://docs.github.com/en/actions/monitoring-and-troubleshooting-workflows/notifications-for-workflow-runs. However, that information is limited to entire workflow statuses, and it makes it only to the one who triggered the workflow (in particular, reviewers don't get it).

If we absolutely want this, then only comment when there is a failure and only include failures?

We added that option here - ipdxco/sorted-pr-checks#5 (comment) I'd suggest still keeping the comment if all the checks have passed. It's an easier lifecycle to manage, and a comment explicitly saying everything's OK means that users do not have to interpret what lack of comment means.

Let us know whether you'd like to proceed with this addition and, if so, with which template :)

@Stebalien
Copy link
Member

Honestly, a single short comment seems reasonable. I personally prefer the one that only lists the failures (or a single "all good"). However, we probably want to collapse the list if we have more than, say, 10 failures (e.g., when one pushes a bad commit and everything fails).

@rvagg
Copy link
Member

rvagg commented Apr 14, 2024

I don't mind a sticky comment with the info, it'll make notifications noisy but if it's consistent then that's probably OK.

A sticky with only failures might be an improvement though, then one only shows up on failures. My notifications already get Circle failure messages but they come in separately to the issue notifications (I use email for these and like the threads to line up). Having failures in a message would probably be a solid improvement and line up nicely in the notifications.

rvagg
rvagg approved these changes Apr 19, 2024
View reviewed changes
Copy link
Member

@rvagg rvagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well, I guess we can give it a try and see how it feels

@galargh galargh merged commit 70e0767 into master Apr 22, 2024
185 of 186 checks passed
@galargh galargh deleted the ipdx-gha-sorted-pr-checks branch April 22, 2024 09:50
snadrus added a commit that referenced this pull request May 2, 2024
@LexLuthr @parthshah1
@galargh @ZenGround0 @forcedebug @jennijuju @rjan90 @rvagg @Stebalien @masih @strahe @snadrus @beck-8 @0x5459 @magik6k @aarshkshah1992
chore: curio: merge master (#11956)
a110986 
* Fixing dead links (#11907)

* ci: ci: create gh workflow that updates sorted pr checks (#11861)

* ci: create gh workflow that updates sorted pr checks

* ci: use grouped_by_result template for pr checks sticky comment

* chore: apply pr review suggestion

* Avoid cfg lookup on chain remove since unenabled splitstore delete is noop anyway (#11916)

Co-authored-by: zenground0 <[email protected]>

* Fix mismatched method names in comments (#11913)

Signed-off-by: forcedebug <[email protected]>

* release: v1.26.3 (#11908) (#11915) (#11922)

* deps: update dependencies to address migration memory bloat

to address memory concerns during a heavy migration

Ref: filecoin-project/go-state-types#260
Ref: whyrusleeping/cbor-gen#96
Ref: filecoin-project/go-amt-ipld#90

* release: prep v1.26.3 patch

Prep v1.26.3 patch release:
- Update changelog, version and make gen + make docsgen-cli

* deps: update cbor-gen to tagged version

deps: update cbor-gen to tagged version

* deps: update go-state-types to tagged version

deps: update go-state-types to tagged version v0.13.2

* chore: deps: update go-state-types to v0.13.3

Fixes a panic when we have fewer than 1k proposals.

---------

Co-authored-by: Phi-rjan <[email protected]>
Co-authored-by: Rod Vagg <[email protected]>
Co-authored-by: Steven Allen <[email protected]>

* Refactor `LookupID*` APIs in `StateManager` and `StateTree`

The naming of `LookupID` can cause confusion when resolving actor IDs vs
 ID addresses. To avoid this:

* Refactor `StateTree` `LookupID` to `LookupIDAddress`, because it
returns ID address.
* Refactor `StateManager` `LookupID` to
`LookupIDAddress` because it also returns ID address via a chain call to
`StateTree`.
* Introduce a new API `StateManager` dedicated to resolving address to
actor ID, called `LookupID` which returns `abi.ActorID`.

For context, see:
 * #11723 (comment)

* Add v13 support to invariants-checker (#11931)

Add v13 support to invariants-checker

* chore: docs: nv-skeleton documentation (#11065)

* nv-skeleton documentation

Add a tutorial for how one can create a nv-skeleton in Lotus

* Add footnote for `Add migration` step

Add footnote for `Add migration` step

* Indent migration-code

Indent migration-code to make it show properly as a footnote.

* Add ref-fvm and filecoin-ffi checklist

Add ref-fvm and filecoin-ffi checklist

* Add Filecoin-FFI steps

Add Filecoin-FFI steps

* Add step to params_butterfly.go

Add step to params_butterfly.go

* Fix typo

Fix typo

* Add links to reference PRs

Add links to reference PRs

* Update ref-fvm list

Update ref-fvm list

* feat: curio: add StorageInit api (#11918)

* feat: add StorageInit api

* remove unused variables

* fix gen check

* feat: curio: simpler reservation release logic (#11900)

* simpler release logic

* oops, plus simpler

* simpler

* fix NewLine (#11893)

* fix(events): check for sync-in-progress (#11932)

* feat(events): adjust indexes in event index db to match query patterns

Introduces a v4 migration that just adjusts indexes.

Copies some improvements from #11723

Closes: #11909

* fix(pipeline): should return if error occurred when get network version (#11902)

* fix(events): correct log msg for v4 events index db migration

* chore: remove duplicate words in strings and comments

* fix(events): register events index db migration v4

* fix: curio seal: Failed commit retry strategy (#11870)

* ffi: improved-error-handling

* curio seal: Failed commit retry strategy

* use master ffi

* mod tidy

* fix: curio: Update pgx imports, fix db_storage alloc

* feat: curioweb: Improve task_history indexes (#11911)

* mod tidy

* Event index should be unique for tipsets (#11952)

* event index should be unique for tipsets

* fix formatting

* migrate to version 5

* chore: bump build version in master (#11946)

* Bump version

Bump version in master branch in preperation for cutting v1.27.0-rc1

* chore: bump build-version

chore: bump build-version

* feat: curioweb: Show piece info on the sector page (#11955)

* curio: feat: break trees task into TreeD(prefetch) and TreeRC (#11895)

* break trees task

* fix TreeD reservation

* fix nil pointer err

* apply suggestions

* fix allocate file types

* fix dbIndex inserts

* set resource, move release func

* refactor func(), update memory

* remove extra release

---------

Signed-off-by: forcedebug <[email protected]>
Co-authored-by: parthshah1 <[email protected]>
Co-authored-by: Piotr Galar <[email protected]>
Co-authored-by: ZenGround0 <[email protected]>
Co-authored-by: zenground0 <[email protected]>
Co-authored-by: forcedebug <[email protected]>
Co-authored-by: Jiaying Wang <[email protected]>
Co-authored-by: Phi-rjan <[email protected]>
Co-authored-by: Rod Vagg <[email protected]>
Co-authored-by: Steven Allen <[email protected]>
Co-authored-by: Masih H. Derkani <[email protected]>
Co-authored-by: Lee <[email protected]>
Co-authored-by: Andrew Jackson (Ajax) <[email protected]>
Co-authored-by: beck <[email protected]>
Co-authored-by: 0x5459 <[email protected]>
Co-authored-by: Łukasz Magiera <[email protected]>
Co-authored-by: Łukasz Magiera <[email protected]>
Co-authored-by: Aarsh Shah <[email protected]>
magik6k added a commit that referenced this pull request May 4, 2024
@snadrus @magik6k
@LexLuthr @parthshah1 @galargh @ZenGround0 @forcedebug @jennijuju @rjan90 @rvagg @Stebalien @masih @strahe @beck-8 @0x5459 @aarshkshah1992
fix: curio: node UI & darwin gpu count (#11950)
441f599 
* fix: curio: Update pgx imports, fix db_storage alloc

* feat: curioweb: Improve task_history indexes (#11911)

* 1

* relatable

* add and delete layer

* chore: curio: merge master (#11956)

* Fixing dead links (#11907)

* ci: ci: create gh workflow that updates sorted pr checks (#11861)

* ci: create gh workflow that updates sorted pr checks

* ci: use grouped_by_result template for pr checks sticky comment

* chore: apply pr review suggestion

* Avoid cfg lookup on chain remove since unenabled splitstore delete is noop anyway (#11916)

Co-authored-by: zenground0 <[email protected]>

* Fix mismatched method names in comments (#11913)

Signed-off-by: forcedebug <[email protected]>

* release: v1.26.3 (#11908) (#11915) (#11922)

* deps: update dependencies to address migration memory bloat

to address memory concerns during a heavy migration

Ref: filecoin-project/go-state-types#260
Ref: whyrusleeping/cbor-gen#96
Ref: filecoin-project/go-amt-ipld#90

* release: prep v1.26.3 patch

Prep v1.26.3 patch release:
- Update changelog, version and make gen + make docsgen-cli

* deps: update cbor-gen to tagged version

deps: update cbor-gen to tagged version

* deps: update go-state-types to tagged version

deps: update go-state-types to tagged version v0.13.2

* chore: deps: update go-state-types to v0.13.3

Fixes a panic when we have fewer than 1k proposals.

---------

Co-authored-by: Phi-rjan <[email protected]>
Co-authored-by: Rod Vagg <[email protected]>
Co-authored-by: Steven Allen <[email protected]>

* Refactor `LookupID*` APIs in `StateManager` and `StateTree`

The naming of `LookupID` can cause confusion when resolving actor IDs vs
 ID addresses. To avoid this:

* Refactor `StateTree` `LookupID` to `LookupIDAddress`, because it
returns ID address.
* Refactor `StateManager` `LookupID` to
`LookupIDAddress` because it also returns ID address via a chain call to
`StateTree`.
* Introduce a new API `StateManager` dedicated to resolving address to
actor ID, called `LookupID` which returns `abi.ActorID`.

For context, see:
 * #11723 (comment)

* Add v13 support to invariants-checker (#11931)

Add v13 support to invariants-checker

* chore: docs: nv-skeleton documentation (#11065)

* nv-skeleton documentation

Add a tutorial for how one can create a nv-skeleton in Lotus

* Add footnote for `Add migration` step

Add footnote for `Add migration` step

* Indent migration-code

Indent migration-code to make it show properly as a footnote.

* Add ref-fvm and filecoin-ffi checklist

Add ref-fvm and filecoin-ffi checklist

* Add Filecoin-FFI steps

Add Filecoin-FFI steps

* Add step to params_butterfly.go

Add step to params_butterfly.go

* Fix typo

Fix typo

* Add links to reference PRs

Add links to reference PRs

* Update ref-fvm list

Update ref-fvm list

* feat: curio: add StorageInit api (#11918)

* feat: add StorageInit api

* remove unused variables

* fix gen check

* feat: curio: simpler reservation release logic (#11900)

* simpler release logic

* oops, plus simpler

* simpler

* fix NewLine (#11893)

* fix(events): check for sync-in-progress (#11932)

* feat(events): adjust indexes in event index db to match query patterns

Introduces a v4 migration that just adjusts indexes.

Copies some improvements from #11723

Closes: #11909

* fix(pipeline): should return if error occurred when get network version (#11902)

* fix(events): correct log msg for v4 events index db migration

* chore: remove duplicate words in strings and comments

* fix(events): register events index db migration v4

* fix: curio seal: Failed commit retry strategy (#11870)

* ffi: improved-error-handling

* curio seal: Failed commit retry strategy

* use master ffi

* mod tidy

* fix: curio: Update pgx imports, fix db_storage alloc

* feat: curioweb: Improve task_history indexes (#11911)

* mod tidy

* Event index should be unique for tipsets (#11952)

* event index should be unique for tipsets

* fix formatting

* migrate to version 5

* chore: bump build version in master (#11946)

* Bump version

Bump version in master branch in preperation for cutting v1.27.0-rc1

* chore: bump build-version

chore: bump build-version

* feat: curioweb: Show piece info on the sector page (#11955)

* curio: feat: break trees task into TreeD(prefetch) and TreeRC (#11895)

* break trees task

* fix TreeD reservation

* fix nil pointer err

* apply suggestions

* fix allocate file types

* fix dbIndex inserts

* set resource, move release func

* refactor func(), update memory

* remove extra release

---------

Signed-off-by: forcedebug <[email protected]>
Co-authored-by: parthshah1 <[email protected]>
Co-authored-by: Piotr Galar <[email protected]>
Co-authored-by: ZenGround0 <[email protected]>
Co-authored-by: zenground0 <[email protected]>
Co-authored-by: forcedebug <[email protected]>
Co-authored-by: Jiaying Wang <[email protected]>
Co-authored-by: Phi-rjan <[email protected]>
Co-authored-by: Rod Vagg <[email protected]>
Co-authored-by: Steven Allen <[email protected]>
Co-authored-by: Masih H. Derkani <[email protected]>
Co-authored-by: Lee <[email protected]>
Co-authored-by: Andrew Jackson (Ajax) <[email protected]>
Co-authored-by: beck <[email protected]>
Co-authored-by: 0x5459 <[email protected]>
Co-authored-by: Łukasz Magiera <[email protected]>
Co-authored-by: Łukasz Magiera <[email protected]>
Co-authored-by: Aarsh Shah <[email protected]>

* linter oops

* gen cleanup

* fix

* named returns are confusing

---------

Signed-off-by: forcedebug <[email protected]>
Co-authored-by: Łukasz Magiera <[email protected]>
Co-authored-by: Łukasz Magiera <[email protected]>
Co-authored-by: LexLuthr <[email protected]>
Co-authored-by: parthshah1 <[email protected]>
Co-authored-by: Piotr Galar <[email protected]>
Co-authored-by: ZenGround0 <[email protected]>
Co-authored-by: zenground0 <[email protected]>
Co-authored-by: forcedebug <[email protected]>
Co-authored-by: Jiaying Wang <[email protected]>
Co-authored-by: Phi-rjan <[email protected]>
Co-authored-by: Rod Vagg <[email protected]>
Co-authored-by: Steven Allen <[email protected]>
Co-authored-by: Masih H. Derkani <[email protected]>
Co-authored-by: Lee <[email protected]>
Co-authored-by: beck <[email protected]>
Co-authored-by: 0x5459 <[email protected]>
Co-authored-by: Aarsh Shah <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rvagg rvagg rvagg approved these changes

@magik6k magik6k Awaiting requested review from magik6k

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@galargh @Stebalien @masih @rvagg