Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sealing: Switch to market-independent pieces in sealing pipeline #11220

Closed
wants to merge 12 commits into from

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Aug 29, 2023

Related Issues

Related to #11125

Imports filecoin-project/go-state-types#209

Proposed Changes

  • Add PieceActivationManifest to api.PieceDealInfo
  • Implement universal getters on PieceDealInfo
  • Create an interface preventing raw value access to PieceDealInfo in the sealing pipeline code, aiding in migration
  • Make things compile and work with the new interface

Additional Info

This PR doesn't add full support for Direct-Data-Onboarding, but it does prepare the sealing pipeline code to work with Pieces that aren't necessarily deals made with the builtin market actor.

Full DDO support will be implemented in a separate, hopefully much smaller PR

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@magik6k magik6k force-pushed the feat/ddo-deal-input branch from ddbfb16 to 62dc44d Compare August 30, 2023 14:18
@magik6k magik6k changed the title [wip] feat: sealing: Support DDO pieces in lotus-miner feat: sealing: Switch to market-independent pieces in sealing pipeline Aug 30, 2023
@magik6k magik6k marked this pull request as ready for review August 30, 2023 15:24
@magik6k magik6k requested a review from a team as a code owner August 30, 2023 15:24
continue
}

dealSafeSealEpoch = piece.DealInfo.DealProposal.StartEpoch - cfg.StartEpochSealingBuffer
startEpoch, err := piece.StartEpoch()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

later should check if there is deal term attached, if not just do sector stuff as it goes

@magik6k magik6k closed this Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

Implementation plan for direct data onboarding proposal' in Lotus-Miner
2 participants