update go-libp2p to v0.30.0 #11189
Merged
update go-libp2p to v0.30.0 #11189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marten-seemann
force-pushed
the
update-go-libp2p-v0300
branch
from
4c167ff
to
652c8c8
Compare
marten-seemann
commented
Aug 21, 2023
| @@ -11,7 +11,8 @@ import ( | |||
| "sync" | |||
| "time" | |||
|
|
|||
| lru "github.com/hashicorp/golang-lru/v2" | |||
| "github.com/hashicorp/golang-lru/arc/v2" | |||
There was a problem hiding this comment.
golang-lru introduced a breaking change in the v2.0.3 patch release. See hashicorp/golang-lru#142 for discussion. The author has his own interpretation of the semver specification, that diverges from everyone else's reading, and seems oblivious to the amount of pain his actions cause in the ecosystem.
marten-seemann
force-pushed
the
update-go-libp2p-v0300
branch
from
652c8c8
to
bca0ec4
Compare
21 tasks
marten-seemann
force-pushed
the
update-go-libp2p-v0300
branch
2 times, most recently
from
36f54b2
to
dbad439
Compare
marten-seemann
force-pushed
the
update-go-libp2p-v0300
branch
from
dbad439
to
d50cf4e
Compare
|
Not sure why some of the tests are failing. Flaky? Could anyone more familiar with the code base please take a look? |
magik6k
reviewed
Aug 22, 2023
magik6k
approved these changes
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes
Additional Info
go-libp2p v0.30.0 allows using Go 1.21. It also drops support for Go 1.19.
Note that this PR does NOT bump the Go version in
go.mod. I tried that, and it leads to a whole lot ofstaticcheckcomplaints. I'll leave this as an exercise for the reader :)Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>fix: mempool: Introduce a cache for valid signaturesPR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps