feat: chainstore: optimize BlockMsgsForTipset #10552
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
@raulk observed some slowness due to the repeated resolution of senders in this method.
It's necessary to resolve senders if AND ONLY IF we have a message sent by an ID address. If we don't (which we almost never do), we can just use robust addresses.
Proposed Changes
Use robust addresses, instead of ID addresses, to check nonces when selecting BlockMsgsForTipset, BUT check if we have any messages sent from ID addresses.
If we do find any messages sent from ID addresses, switch to using ID addresses for the resolution.
Speeds up BlockMsgsForTipset from ~25ms on average to ~5 ms on average (on my desktop).
Additional Info
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>
fix: mempool: Introduce a cache for valid signatures
PR type
: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea
, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps