Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

evm: feat: always call contracts on InvokeContract #10132

Closed
wants to merge 1 commit into from

Conversation

Stebalien
Copy link
Member

This:

  1. Always uses InvokeContract, never reducing to a method-0 value transfer.
  2. Always encodes the parameters as a cbor byte array for simplicity.

This removes many edge cases and makes it possible to run contract
logic with no parameters.

Depends on filecoin-project/ref-fvm#1567

Fixes the issues outlined in filecoin-project/ref-fvm#1302

NOTE: This change doesn't include any network version checks. We'll have to implement hyperspace specific ones in a separate PR.

@Stebalien Stebalien requested a review from a team as a code owner January 26, 2023 23:50
@Stebalien Stebalien marked this pull request as draft January 26, 2023 23:50
@Stebalien
Copy link
Member Author

We need to release/bubble the FVM first.

@Stebalien
Copy link
Member Author

FIP changes: filecoin-project/FIPs#606

@Stebalien Stebalien changed the title evm: feat: always call contracts on InvokeContract evm: feat: always call contracts on InvokeContract (hacky version) Jan 27, 2023
@Stebalien Stebalien changed the title evm: feat: always call contracts on InvokeContract (hacky version) evm: feat: always call contracts on InvokeContract Jan 27, 2023
This:

1. Always uses InvokeContract, never reducing to a method-0 value transfer.
2. Always encodes the parameters as a cbor byte array for simplicity.

This removes _many_ edge cases and makes it possible to run contract
logic with no parameters.

Depends on filecoin-project/ref-fvm#1567

Fixes the issues outlined in filecoin-project/ref-fvm#1302
@jennijuju jennijuju added this to the Network v18 milestone Feb 6, 2023
@Stebalien
Copy link
Member Author

@Stebalien Stebalien closed this Feb 13, 2023
@raulk raulk deleted the steb/eth-always-call branch February 13, 2023 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants