evm: feat: always call contracts on InvokeContract #10132
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We need to release/bubble the FVM first. |
|
FIP changes: filecoin-project/FIPs#606 |
Stebalien
changed the title
Stebalien
changed the title
This: 1. Always uses InvokeContract, never reducing to a method-0 value transfer. 2. Always encodes the parameters as a cbor byte array for simplicity. This removes _many_ edge cases and makes it possible to run contract logic with no parameters. Depends on filecoin-project/ref-fvm#1567 Fixes the issues outlined in filecoin-project/ref-fvm#1302
Stebalien
force-pushed
the
steb/eth-always-call
branch
from
ad99ddb
to
7a1632f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This:
This removes many edge cases and makes it possible to run contract
logic with no parameters.
Depends on filecoin-project/ref-fvm#1567
Fixes the issues outlined in filecoin-project/ref-fvm#1302
NOTE: This change doesn't include any network version checks. We'll have to implement hyperspace specific ones in a separate PR.