named returns are confusing

filecoin-project · May 2, 2024 · 5a77225 · 5a77225
1 parent b79a1e0
commit 5a77225
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/curiosrc/web/hapi/simpleinfo.go b/curiosrc/web/hapi/simpleinfo.go
@@ -584,7 +584,7 @@ func (a *app) clusterMachineSummary(ctx context.Context) ([]machineSummary, erro
 	}
 
 	// Then machine summary
-	rows, err := a.db.Query(ctx, "SELECT id, host_and_port, CURRENT_TIMESTAMP - last_contact, cpu, ram, gpu AS last_contact FROM harmony_machines order by host_and_port asc")
+	rows, err := a.db.Query(ctx, "SELECT id, host_and_port, CURRENT_TIMESTAMP - last_contact AS last_contact, cpu, ram, gpu FROM harmony_machines order by host_and_port asc")
 	if err != nil {
 		return nil, err // Handle error
 	}

diff --git a/storage/paths/local.go b/storage/paths/local.go
@@ -462,13 +462,13 @@ func (st *Local) reportStorage(ctx context.Context) {
 	}
 }
 
-func (st *Local) Reserve(ctx context.Context, sid storiface.SectorRef, ft storiface.SectorFileType, storageIDs storiface.SectorPaths, overheadTab map[storiface.SectorFileType]int, minFreePercentage float64) (release func(), err error) {
-	var ssize abi.SectorSize
-	ssize, err = sid.ProofType.SectorSize()
+func (st *Local) Reserve(ctx context.Context, sid storiface.SectorRef, ft storiface.SectorFileType,
+	storageIDs storiface.SectorPaths, overheadTab map[storiface.SectorFileType]int, minFreePercentage float64) (func(), error) {
+	ssize, err := sid.ProofType.SectorSize()
 	if err != nil {
 		return nil, err
 	}
-	release = func() {}
+	release := func() {}
 
 	st.localLk.Lock()