fix(big)!: treat uninitialized big.Int as zero#360
Merged
Conversation
rvagg
force-pushed
the
rvagg/fip-0100/type-updates
branch
2 times, most recently
from
792b023 to
d3ca895
Compare
Member
|
I'd consider merging this change regardless (and, in that case, I'd merge it into master and rebase on it). We never actually want to panic if this is nil, and it's still possible to distinguish between nil and zero. |
Member
Author
|
filecoin-project/lotus#12936 has this pulled in to Lotus, looking at itest coverage for now. |
ZenGround0
approved these changes
Mar 6, 2025
github-project-automation
Bot
moved this from 📌 Triage
to ✔️ Approved by reviewer
in FilOz
Member
Author
|
ok, let's do this then |
rvagg
changed the title
github-project-automation
Bot
moved this from ✔️ Approved by reviewer
to 🎉 Done
in FilOz
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.