Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate CARv2 Blockstore resumption #572

Merged
merged 3 commits into from
Jul 15, 2021

Conversation

aarshkshah1992
Copy link
Collaborator

@aarshkshah1992 aarshkshah1992 commented Jul 14, 2021

@dirkmc Couple of tests are failing as discussed offline.

@aarshkshah1992 aarshkshah1992 changed the base branch from master to feat/wip-markets-dagstore July 14, 2021 08:27
@dirkmc
Copy link
Contributor

dirkmc commented Jul 14, 2021

Both these tests are now failing with the same error: cannot resume from a finalized file

This is because the CAR file has been finalized but we are trying to open it as a file that can be written to.

@aarshkshah1992
Copy link
Collaborator Author

@dirkmc Let's wait till the tests are green.

@codecov-commenter
Copy link

Codecov Report

Merging #572 (e1151f8) into feat/wip-markets-dagstore (ff52af4) will not change coverage.
The diff coverage is 25.00%.

Impacted file tree graph

@@                    Coverage Diff                     @@
##           feat/wip-markets-dagstore     #572   +/-   ##
==========================================================
  Coverage                      65.18%   65.18%           
==========================================================
  Files                             65       65           
  Lines                           4523     4523           
==========================================================
  Hits                            2948     2948           
  Misses                          1300     1300           
  Partials                         275      275           
Impacted Files Coverage Δ
carstore/read_write_blockstore.go 84.62% <ø> (ø)
storagemarket/impl/provider_environments.go 9.38% <0.00%> (ø)
...oragemarket/impl/providerstates/provider_states.go 86.22% <50.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff52af4...e1151f8. Read the comment docs.

@aarshkshah1992 aarshkshah1992 merged commit e6c3d53 into feat/wip-markets-dagstore Jul 15, 2021
@aarshkshah1992 aarshkshah1992 deleted the feat/use-latest-carv2 branch July 15, 2021 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants