-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TestF3LateBootstrap
is flaky
#847
Milestone
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Over the course of latest development in this repo
TestF3LateBootstrap
is pupped up a number of times as being flaky. It's timeout has already been bumped to 1m, and it is the slowest test we have in this repo.One cause that I have observed is that phases time out before messages are delivered which results in repeated base decision and causes assertions that check if a certain epoch is finalised take too long. A root cause is the way mock clock is used in the tests: it is used to grow the chain and gpbft. Another issue is the way clock advancing works relative to assertion checks. As is the test is very CPU hungry as it runs assertions in a hot-loop.
I captured this as a separate issue from #818 to emphasise the need for making this test run faster as it slows down development.
The text was updated successfully, but these errors were encountered: