Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup channel in a go-routine #227

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Cleanup channel in a go-routine #227

wants to merge 1 commit into from

Conversation

aarshkshah1992
Copy link
Collaborator

go-statemachine dosen't process additional events till this state handler function executes. We should do the cleanup in a go-routine.

hannahhoward
hannahhoward reviewed Jul 29, 2021
View reviewed changes
Copy link
Collaborator

@hannahhoward hannahhoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we have any evidence this is ever taking a long time? or is this just a precaution?

Asking cause I think we need to be careful about logic changes this close to M1 unless we believe for sure that it is related to the most recent issues.

This was referenced Oct 4, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hannahhoward hannahhoward hannahhoward left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aarshkshah1992 @hannahhoward