Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store the count of unique Receieved cids #216

Closed
wants to merge 2 commits into from

Conversation

aarshkshah1992
Copy link
Collaborator

@aarshkshah1992 aarshkshah1992 commented Jun 3, 2021

This PR introduces the minimal set of changes we need to fix the logging hotspot in Lotus that happens because of reading the entire list of received cids from disk.

Lotus PR at:
filecoin-project/lotus#6385

@dirkmc I've made this PR against master but we need to merge it into v1.6.0 as well and release to avoid the latest changes in master from making their way to these fixes, right ?

@aarshkshah1992 aarshkshah1992 changed the base branch from master to release/v0.6.1 June 3, 2021 09:16
@aarshkshah1992 aarshkshah1992 changed the base branch from release/v0.6.1 to master June 3, 2021 09:17
@codecov-commenter
Copy link

Codecov Report

Merging #216 (8f4ef36) into master (db84ad0) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #216      +/-   ##
==========================================
+ Coverage   64.84%   64.88%   +0.04%     
==========================================
  Files          24       24              
  Lines        2600     2603       +3     
==========================================
+ Hits         1686     1689       +3     
  Misses        573      573              
  Partials      341      341              
Impacted Files Coverage Δ
channels/channel_state.go 81.08% <100.00%> (+0.52%) ⬆️
channels/channels_fsm.go 63.93% <100.00%> (+0.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db84ad0...8f4ef36. Read the comment docs.

@dirkmc dirkmc mentioned this pull request Jun 3, 2021
3 tasks
@dirkmc
Copy link
Contributor

dirkmc commented Jun 4, 2021

Closing in favour of #217

@dirkmc dirkmc closed this Jun 4, 2021
This was referenced Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants