Skip to content

fix: retry on CreateDataSet nonce collision#72

Closed
rvagg wants to merge 3 commits intomainfrom
rvagg/dataset-collision-retry
Closed

fix: retry on CreateDataSet nonce collision#72
rvagg wants to merge 3 commits intomainfrom
rvagg/dataset-collision-retry

Conversation

@rvagg
Copy link
Copy Markdown
Member

@rvagg rvagg commented Oct 15, 2025

Ref: https://filecoinproject.slack.com/archives/C095WFA0QK1/p1760475750636059

There are two variations of the errors that we can expect to receive from the server, for reasons:

failed to estimate gas: failed to estimate gas: message execution failed: exit 33, reason: message failed with backtrace:
00: f0169791 (method 3844450837) -- contract reverted at 75 (33)
01: f0169791 (method 6) -- contract reverted at 4535 (33)
02: f0169800 (method 3844450837) -- contract reverted at 75 (33)
03: f0169800 (method 6) -- contract reverted at 18957 (33)
 (RetCode=33)
failed to estimate gas: message execution failed (exit=[33], revert reason=[message failed with backtrace:
00: f0169791 (method 3844450837) -- contract reverted at 75 (33)
01: f0169791 (method 6) -- contract reverted at 4535 (33)
02: f0169800 (method 3844450837) -- contract reverted at 75 (33)
03: f0169800 (method 6) -- contract reverted at 18957 (33)
 (RetCode=33)], vm error=[0x42d750dc0000000000000000000000000542c82a785fab8b53c7c59aaad7093d87265f3a0000000000000000000000009050bdd028ba54a01777cd8c6d0a59d5bc52fdbf])

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 15, 2025

Filecoin Pin Upload

IPFS Artifacts:

Onchain verification:

Payment:

  • Current Filecoin Pay balance: 1116.3342 USDFC

  • Amount deposited to Filecoin Pay by this workflow: 0.0000 USDFC

  • Data Set Storage runway: 10376 year(s) 2 month(s) 21 day(s)

    More details

Copy link
Copy Markdown
Collaborator

@SgtPooki SgtPooki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this actually looks really straightforward for the dataset creation failures

@SgtPooki
Copy link
Copy Markdown
Collaborator

i'm going to test this locally with two (or more) simultaneous new private windows and merge if it works

@vercel
Copy link
Copy Markdown

vercel Bot commented Oct 17, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
filecoin-pin-website Ready Ready Preview Comment Oct 17, 2025 0:30am

@SgtPooki
Copy link
Copy Markdown
Collaborator

it looks like a react-state error needs to be fixed. we're currently preventing duplicate data-set creation requests, and that doesn't seem to be handled here:

index-UvSOCQw6.js:362 [DataSet] Nonce collision detected (attempt 1/4), retrying...
index-UvSOCQw6.js:362 [DataSet] Already initializing (status check), skipping duplicate request

will fix

@SgtPooki
Copy link
Copy Markdown
Collaborator

SgtPooki commented Oct 17, 2025

@rvagg @BigLep it looks like we need a longer wait if there's a collision.. because one of the users (private browser instances for me) started creating a dataset, and the other got to the 4 retries almost instantely and just failed with the same error..

the data set creation needs to wait at least <expected-data-set-creation-time> seconds for this retry to work

@rvagg
Copy link
Copy Markdown
Member Author

rvagg commented Oct 20, 2025

oh whoops, I thought I had a wait in here

anyway, let's hold off on this, we'll get this sorted soon enough with nonsequential nonces

@BigLep BigLep added team/filecoin-pin "Filecoin Pin" project is a stakeholder for this work. team/fs-wg FOC working group is a stakeholder for this work, and thus wants to track it on their project board. labels Oct 29, 2025
@FilOzzy FilOzzy added this to FOC Oct 29, 2025
@github-project-automation github-project-automation Bot moved this to 📌 Triage in FOC Oct 29, 2025
@BigLep BigLep moved this from 📌 Triage to ⌨️ In Progress in FOC Oct 29, 2025
@rvagg rvagg closed this Oct 30, 2025
@github-project-automation github-project-automation Bot moved this from ⌨️ In Progress to 🎉 Done in FOC Oct 30, 2025
@rvagg rvagg deleted the rvagg/dataset-collision-retry branch October 30, 2025 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

team/filecoin-pin "Filecoin Pin" project is a stakeholder for this work. team/fs-wg FOC working group is a stakeholder for this work, and thus wants to track it on their project board.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants