use ChainExportRangeInternal to write snapshots directly to disk #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we expect this to be perform much better, than using the ChainExport method and streaming it through the API. this commit only guarantees that filecoin-chain-archiver binary builds. writing some tests and doing manual testing is still required.
ognots
force-pushed
the
feat/chain-export-range
branch
from
465adb8
to
82b7727
Compare
* fixes a lot of bugs, found through local testing * now that lotus support importing zstd compressed snapshots, don't even bother with the raw snapshots
trying to test this without access to lotus daemon volumes
the snapshot car files are continually appended to while the ExportRangeInternal process executes. if one uses the os.File io.Reader, it will encounter an EOF before the snapshot is complete. our custom io.Reader returns an io.EOF when the ExportRangeInternal method completes
* do some refactoring so we can pipe the zstd encoded snapshot to file for debugging * select statement in custom reader was blocking without setting default
ognots
force-pushed
the
feat/chain-export-range
branch
from
3cb7c09
to
2f4c58b
Compare
initiate reader and pass it in as argument to newSnapshotReader. also do some cleanup
ognots
force-pushed
the
feat/chain-export-range
branch
2 times, most recently
from
88dcb4c
to
55bb87d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we expect this to be perform much better, than using the ChainExport method and streaming it through the API.
this commit only guarantees that filecoin-chain-archiver binary builds. writing some tests and doing manual testing is still required.