Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deal label storage in DB #310

Merged
merged 1 commit into from
Oct 30, 2024
Merged

fix: deal label storage in DB #310

merged 1 commit into from
Oct 30, 2024

Conversation

LexLuthr
Copy link
Contributor

@LexLuthr LexLuthr commented Oct 30, 2024

We save the label as bytes outside of the proposal and then read the same each time we need proposal. Proposal in sector_metadata and pipeline will still be missing this label but we don't really care about that as Label is only useful for market process.

Copy link
Collaborator

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine. A little bit messy, but that problem is mk12-only, so eventually in far future will be deprecated away.

@magik6k magik6k merged commit f776a57 into feat/market Oct 30, 2024
14 checks passed
@magik6k magik6k deleted the fix/deal-label branch October 30, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants