-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unseal #181
Merged
Merged
Unseal #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 tasks
magik6k
force-pushed
the
feat/unseal
branch
2 times, most recently
from
September 2, 2024 11:13
9c3e4af
to
bf57350
Compare
magik6k
force-pushed
the
feat/unseal
branch
2 times, most recently
from
September 4, 2024 13:38
f250428
to
d579d2e
Compare
snadrus
approved these changes
Sep 5, 2024
LexLuthr
approved these changes
Sep 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good with some small nits.
magik6k
force-pushed
the
feat/unseal
branch
4 times, most recently
from
September 6, 2024 15:00
cdf1bc9
to
20bf029
Compare
snadrus
reviewed
Sep 9, 2024
magik6k
force-pushed
the
feat/unseal
branch
from
September 10, 2024 10:04
dfe4538
to
b438cc4
Compare
magik6k
force-pushed
the
feat/unseal
branch
from
September 10, 2024 10:06
b438cc4
to
3718186
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tldr
This PR adds an unseal pipeline along with a simple tagging system on sectors which allows SPs to specify the desired sector unseal state.
Sector target-unseal mark
Sectors now have a
target_unseal_state
marker which has 3 states:none
(default) - don't do anything relating to the unsealed file. If it's there don't remove, if it's not there don't unsealfalse
- mark for GC when it appears in storage (only removes after the GC mark is separately approved)true
- currently, when the value flips from other state to true AND the unsealed file isn't present in storage an entry for the sector will be added to the unseal pipelineUnseal Pipeline
The unseal pipeline is vastly more robust than unseal requests in lotus-miner ever were, and at the same time much simpler. There are only two tasks:
SDRKeyRegen
- creates sector key on an SDR workerUnsealDecode
- gets (potentially remote) streams of the sector key and sealed data, and outputs unsealed data straight to long-term-storageTools
Some tools added in this PR:
curio unseal info
- outputs most relevant information about unsealed sector datacurio unseal list-sectors
- very basic aggregate output dumping the unseal pipeline state + target unseal states, output is not pretty but enough for visibilitycurio unseal set-target-state [spid] [sector] [true/false/none]
- setting target unseal state for sectorscurio unseal check [spid] [sector]
- run a CommP on stored unsealed file to verify its integritytodo