Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ineffective optimisation of HAMT writes in ExtendClaimTerms #680

Merged
merged 1 commit into from
Sep 20, 2022

Conversation

anorth
Copy link
Member

@anorth anorth commented Sep 19, 2022

See discussion #669 (comment)

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (decouple-fil+@f8847e0). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff                @@
##             decouple-fil+     #680   +/-   ##
================================================
  Coverage                 ?   84.68%           
================================================
  Files                    ?       95           
  Lines                    ?    19057           
  Branches                 ?        0           
================================================
  Hits                     ?    16139           
  Misses                   ?     2918           
  Partials                 ?        0           

Copy link
Contributor

@ZenGround0 ZenGround0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thanks

@anorth anorth changed the title Remove ineffective optimisation of HAMT writes in extend claim terms Remove ineffective optimisation of HAMT writes in ExtendClaimTerms Sep 20, 2022
@anorth anorth merged commit 46ee82a into decouple-fil+ Sep 20, 2022
@anorth anorth deleted the anorth/extendclaimopt branch September 20, 2022 21:22
shamb0 pushed a commit to shamb0/builtin-actors that referenced this pull request Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants