Upgrade fungible token library. Use standard exit codes. Use standard token method params/return types. #580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… token method params/return types.
ZenGround0
approved these changes
Aug 28, 2022
actors/datacap/src/lib.rs
Outdated
| Token::with(msg.rt.store(), &msg, &mut st.token, DATACAP_GRANULARITY, |token| { | ||
| token.allowance(¶ms.owner, ¶ms.operator).exit_code(ExitCode::USR_UNSPECIFIED) | ||
| }) | ||
| let token = Token::wrap(msg.rt.store(), &msg, DATACAP_GRANULARITY, &mut st.token); |
There was a problem hiding this comment.
Getting a wrapped token might be a candidate for a state function.
There was a problem hiding this comment.
The lifetimes were tricky to deal with, but I managed to get just this line out to a helper function. I would like to get the Messenger out too, but don't know how to manage its lifetime.
anorth
added a commit
that referenced
this pull request
Aug 28, 2022
… token method params/return types. (#580)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to latest
maincommit on the token library branch.The token receiver flow is a little awkward, the library has plans to improve this.
Closes #534. Closes #535.
FYI @alexytsu @abright