-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add proof types for synthetic porep (FIP-0059) #1409
Conversation
Alternatively, after your branch is merged, I could rebase against |
I was going to do it in two PRs. |
Ok, that works, thanks |
44bc21b
to
3390d45
Compare
This looks correct, but I think this'll need to be tested in a devnet before we can actually be sure we haven't missed something. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1409 +/- ##
==========================================
- Coverage 91.07% 91.01% -0.07%
==========================================
Files 145 145
Lines 27397 27409 +12
==========================================
- Hits 24951 24945 -6
- Misses 2446 2464 +18
|
@@ -502,7 +505,8 @@ mod miner_actor_test_commitment { | |||
), | |||
); | |||
rt.reset(); | |||
precommit_params.seal_proof = RegisteredSealProof::StackedDRG32GiBV1P1; | |||
precommit_params.seal_proof = | |||
RegisteredSealProof::StackedDRG32GiBV1P1_Feat_SyntheticPoRep; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we want to change any existing tests here. Possibly we need some new tests, but if this value is just plumbed directly to the syscall, we're probably ok without.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! If we do end up needing a separate test, let's figure out the best way to do that.
@Stebalien everything needs testing in devnet, right? I don't think that should hold us off from merging code towards FIP-approved changes into master. Integration will be difficult enough regardless. |
Yeah, that's fine by me. I'd say that this change is especially hard to get confidence on without that, but there's no harm in merging and testing later. |
Fwiw, we have done a couple of rounds of testing (local + butterfly) with a locally built actors bundle based of https://github.com/filecoin-project/builtin-actors/tree/dev/synth-porep-1 in Lotus. Plan on the Lotus side is to do a round of SynthPoRep-regression test in a devnet, and also reset butterfly next week-ish. It would be really useful to have these changes in "tag/release", so we can get a bundle as an artifact, instead of building it locally. |
We now need to explicitly specify the sha3/ripemd features when testing (it was removed from shared).
feat: updates to use latest fvm releases
a489c8a
to
ef8c246
Compare
Rebased against |
@Stebalien this LGTM, could you please merge after verifying for yourself? |
@rjan90's testing is enough for me and I don't have a setup where I could verify this. |
@Stebalien Does this help as an alternative to #1335?