feat: remove beneficiary from self-destruct #1362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We need to merge the parent PR first and will have to do a "breaking change" dance regardless. |
Stebalien
force-pushed
the
steb/remove-beneficiary
branch
2 times, most recently
from
8f9a7e8
to
19d2843
Compare
Stebalien
commented
Aug 11, 2023
| if *self.in_transaction.borrow() { | ||
| return Err( | ||
| actor_error!(assertion_failed; "delete_actor is not allowed during transaction"), | ||
| ); | ||
| } | ||
| Ok(fvm::sself::self_destruct(beneficiary)?) | ||
| Ok(fvm::sself::self_destruct(false)?) |
There was a problem hiding this comment.
Passing false here will cause self_destruct to fail if there are any remaining funds. At the moment, that's the only behavior we want in the builtin actors.
Stebalien
force-pushed
the
steb/remove-beneficiary
branch
from
19d2843
to
9e5b136
Compare
Stebalien
added a commit
that referenced
this pull request
Sep 21, 2023
Stebalien
added a commit
that referenced
this pull request
Sep 28, 2023
Stebalien
added a commit
that referenced
this pull request
Sep 28, 2023
Stebalien
added a commit
that referenced
this pull request
Sep 29, 2023
Stebalien
added a commit
that referenced
this pull request
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of filecoin-project/ref-fvm#1837