fix: clean up and fix retrieval framework & tests #1848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use new go-trustless-utils primitives and traversal tools * Simplify Framework#Retrieve
LexLuthr
approved these changes
Dec 19, 2023
LexLuthr
added a commit
that referenced
this pull request
Feb 19, 2024
* remove gfm, pull datatransfer * make gen, docsgen * fix circular depndencies * go mod tidy * fix lint errors * convert RetrievalAskGetter to interface * fix interface pointer * fix dependency injection, move ask db * fix itests * clean up mocks * chore: lots more dt & gs debugging (#1776) * fix lint errs, add back ProviderDataTransfer * regenrate cbor * cleanup go-data-transfer * fix graphsync retrievals * use new client for GS tests * fix selector type * restore selector type * fix: clean up and fix retrieval framework & tests (#1848) * fix: clean up and fix retrieval framework & tests * Use new go-trustless-utils primitives and traversal tools * Simplify Framework#Retrieve * fix: wait for full startup of data transfer when making client * fix lint errors * fix go mod * cleanup itest fixtures, fix gql * go mod tidy * fix directDealProv * handle storage ask * cleanup config * remove graphsync unit tests * add retrieval config headers * update retrieval configs * fix storage ask db command * fix BoostLegacyDealByProposalCid api * make cbor-gen * fix missing api example * migrate config, dump dagstore config --------- Co-authored-by: Rod Vagg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some lint errors in here that can be taken care of separately.