integrate direct data onboarding (nv22) #1847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ischasny
approved these changes
Jan 8, 2024
nonsense
force-pushed
the
nonsense/ddo-nv22
branch
5 times, most recently
from
c520e0a
to
997ddcf
Compare
nonsense
force-pushed
the
nonsense/ddo-nv22
branch
3 times, most recently
from
9280986
to
e9d3163
Compare
nonsense
requested review from
ischasny and
LexLuthr
and removed request for
ischasny
LexLuthr
approved these changes
Feb 13, 2024
There was a problem hiding this comment.
The itest filename for DDO needs be update from .god to .go.
The itest needs be uncommented in circleci config.
I am not sure why we are merging this now as Lotus still hasn't released an RC with the changes. My recommendation would be to wait for it to avoid any possible dependency issues.
itests/ddo_test.god
Outdated
| @@ -98,6 +99,6 @@ func TestDirectDeal(t *testing.T) { | |||
| t.Log("Direct data import scheduled for execution") | |||
|
|
|||
| // TODO: uncomment once lotus has updated actors bundle and sealing works | |||
There was a problem hiding this comment.
Suggested change
| // TODO: uncomment once lotus has updated actors bundle and sealing works |
nonsense
force-pushed
the
nonsense/ddo-nv22
branch
from
e9d3163
to
0639294
Compare
|
@LexLuthr LGTM -- changes to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIP: filecoin-project/FIPs#730
Lotus: filecoin-project/lotus#11226
go-state-types: filecoin-project/go-state-types#236
Blockers