Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update deal list page #1837

Merged
merged 3 commits into from
Dec 4, 2023
Merged

Update deal list page #1837

merged 3 commits into from
Dec 4, 2023

Conversation

LexLuthr
Copy link
Collaborator

@LexLuthr LexLuthr commented Dec 1, 2023 •
edited
Loading

This PR makes the following changes:

  1. Add a new column for on chain deal ID (Boost and Legacy deals)
Screenshot 2023-12-01 at 5 48 30 PM Screenshot 2023-12-01 at 5 47 46 PM 2. Create a new column "Sealing Status" and create an info button with description Screenshot 2023-12-01 at 5 47 52 PM
  1. Add info button to deal Status column
Screenshot 2023-12-01 at 5 48 00 PM
  1. Fix Size for offline deals (we cannot fix for existing deals but new ones should display and retain correct size)
Screenshot 2023-12-04 at 2 41 46 PM Screenshot 2023-12-04 at 2 45 52 PM
  1. The onchainDealID and epochs do not have comma anymore
Screenshot 2023-12-01 at 5 48 13 PM

nonsense
nonsense reviewed Dec 4, 2023
View reviewed changes
react/src/DealDetail.js Outdated Show resolved Hide resolved
@LexLuthr @nonsense
Update react/src/DealDetail.js
3cdb6d3 
Co-authored-by: Anton Evangelatov <[email protected]>
@LexLuthr LexLuthr merged commit ca748c3 into main Dec 4, 2023
21 checks passed
@LexLuthr LexLuthr deleted the fix/ui-deals-page branch December 4, 2023 12:20
@LexLuthr LexLuthr mentioned this pull request Dec 4, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nonsense nonsense nonsense approved these changes

@ischasny ischasny Awaiting requested review from ischasny

Assignees
No one assigned
Labels
None yet
Projects
Boost
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LexLuthr @nonsense