Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix LID web UI #1745

Merged
merged 4 commits into from
Oct 11, 2023
Merged

fix LID web UI #1745

merged 4 commits into from
Oct 11, 2023

Conversation

nonsense
Copy link
Member

@nonsense nonsense commented Oct 10, 2023

Fixed division by zero at two places, which can happen if Boost is installed on a new SP that has 0 deals.

Also small fix for debug level logging from boostd-data service.

We probably need an RC, such as Boost v2.1.1 after this is merged, @LexLuthr, WDYT?

TODO:

  • make sure LID Web UI is displayed correctly with 0 deals
  • make sure that boostd-data second process is used by boostd, and not an internal leveldb service for LID

@nonsense nonsense marked this pull request as ready for review October 10, 2023 12:42
@nonsense nonsense marked this pull request as draft October 10, 2023 12:57
@LexLuthr
Copy link
Collaborator

UI if fixes now
Screenshot 2023-10-10 at 5 12 46 PM

@LexLuthr
Copy link
Collaborator

I think we should release RC2 with this.

@nonsense nonsense marked this pull request as ready for review October 11, 2023 09:43
@nonsense nonsense merged commit 9284541 into main Oct 11, 2023
21 checks passed
@nonsense nonsense deleted the nonsense/fix-lid-web-ui branch October 11, 2023 09:44
nonsense added a commit that referenced this pull request Oct 13, 2023
* handle case when total=0

* handle count=0

* add loggers for debug level -vv

* handle empty lastscan time

---------

Co-authored-by: LexLuthr <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants