ci: switch macos builds to apple silicon #1726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@galargh Can you rebase this on latest main? We have some changes related to go versioning. We also need to fix the failing Github build. |
galargh
force-pushed
the
ci/macos-m1-medium-gen1
branch
from
9ac7b09
to
18aa678
Compare
|
@LexLuthr Done! Seems like it resolved the issues we've been seeing in the CI too. |
LexLuthr
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I false advertised switch to Apple Silicon in #1720. In that PR I only moved us to a generation of runners that is going to continue to work until January 2024 - so it buys us a little bit of time. This PR is the one that truly switches the builds to Apple Silicon. I'll mark it as ready for review once the CI passes.